Re: [Qemu-devel] [PATCH] linux-user: set minimum uname for RISC-V

[Palmer Dabbelt]

On Tue, 24 Apr 2018 09:03:29 PDT (-0700), address@hidden wrote:
> As support was merged into the mainline kernel at 4.15 it is unlikely
> 3.8.0 is the correct value. Indeed when I testing binaries created by
> the current Debian SID compiler the tests failed with:
>
>   FATAL: kernel too old
>
> Signed-off-by: Alex Bennée <address@hidden>
> ---
>  linux-user/riscv/target_syscall.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/linux-user/riscv/target_syscall.h 
> b/linux-user/riscv/target_syscall.h
> index d4e109a27f..ee81d8bc88 100644
> --- a/linux-user/riscv/target_syscall.h
> +++ b/linux-user/riscv/target_syscall.h
> @@ -45,7 +45,7 @@ struct target_pt_regs {
>  #else
>  #define UNAME_MACHINE "riscv64"
>  #endif
> -#define UNAME_MINIMUM_RELEASE "3.8.0"
> +#define UNAME_MINIMUM_RELEASE "4.15.0"
>
>  #define TARGET_MINSIGSTKSZ 2048
>  #define TARGET_MLOCKALL_MCL_CURRENT 1

If I understand this correctly, this will make host kernels older than 4.15.0 
look like 4.15.0 when a program running in user-mode emulation on a RISC-V 
system?  I think that's the correct thing to do, so if that's the case then 
feel free to add a

   Reviewed-by: Palmer Dabbelt <address@hidden>

if that helps any.

Thanks!