Re: [Qemu-devel] [PATCH] qemu-guest-agent: freeze-hook to ignore dpkg files as well

[Philippe Mathieu-Daudé]

Hi Christian,

On 04/09/2018 04:18 AM, Christian Ehrhardt wrote:
> Re-Ping for consideration?
> 
> On Mon, Jan 22, 2018 at 3:03 PM, Christian Ehrhardt <
> address@hidden> wrote:
> 
>> Hi,
>> maybe I missed a formal thing on this submission, but I don't see it right
>> away.

You missed to Cc the maintainer of this file:

$ ./scripts/get_maintainer.pl -f scripts/qemu-guest-agent/fsfreeze-hook
Michael Roth <address@hidden> (maintainer:QEMU Guest Agent)

(I Cc'ed him).

See https://wiki.qemu.org/Contribute/SubmitAPatch#CC_the_relevant_maintainer

>> So for now just a ping on any updates in regard to accept this?
>>
>> On Wed, Dec 13, 2017 at 11:17 AM, Christian Ehrhardt
>> <address@hidden> wrote:
>>> The hook already skips a set of rpm upgrade artifacts.
>>> Do the same with such files that might be created by dpkg.
>>>
>>> Fixes: https://bugs.launchpad.net/ubuntu/+source/qemu/+bug/1484990
>>>
>>> Signed-off-by: Christian Ehrhardt <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

>>> ---
>>>  scripts/qemu-guest-agent/fsfreeze-hook | 2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/scripts/qemu-guest-agent/fsfreeze-hook
>> b/scripts/qemu-guest-agent/fsfreeze-hook
>>> index c27b29f..13aafd4 100755
>>> --- a/scripts/qemu-guest-agent/fsfreeze-hook
>>> +++ b/scripts/qemu-guest-agent/fsfreeze-hook
>>> @@ -13,7 +13,7 @@ FSFREEZE_D=$(dirname -- "$0")/fsfreeze-hook.d
>>>  # Check whether file $1 is a backup or rpm-generated file and should be
>> ignored
>>>  is_ignored_file() {
>>>      case "$1" in
>>> -        *~ | *.bak | *.orig | *.rpmnew | *.rpmorig | *.rpmsave |
>> *.sample)
>>> +        *~ | *.bak | *.orig | *.rpmnew | *.rpmorig | *.rpmsave |
>> *.sample | *.dpkg-old | *.dpkg-new | *.dpkg-tmp | *.dpkg-dist | *.dpkg-bak
>> | *.dpkg-backup | *.dpkg-remove)
>>>              return 0 ;;
>>>      esac
>>>      return 1
>>> --
>>> 2.7.4