Re: [Qemu-devel] [RFC PATCH 09/17] replay: introduce breakpoint at the specified step

[Eric Blake]

On 04/25/2018 07:46 AM, Pavel Dovgalyuk wrote:
> This patch introduces replay_break qmp and hmp commands.
> These commands allow stopping at the specified instruction.
> It may be useful for debugging when there are some known
> events that should be investigated.
> The commands have one argument - number of instructions
> executed since the start of the replay.
> 
> Signed-off-by: Pavel Dovgalyuk <address@hidden>
> ---

> +++ b/qapi/misc.json
> @@ -3485,3 +3485,20 @@
>  ##
>  { 'command': 'info_replay',
>    'returns': 'ReplayInfo' }
> +
> +##
> +# @replay_break:

This should be 'replay-break' (QMP commands should favor '-' over '_').

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature