Re: [Qemu-devel] [PATCH v3 43/46] tests/tcg/Makefile: update to be called from Makefile.target

[Richard Henderson]

On 04/25/2018 11:30 PM, Alex Bennée wrote:
> 
> Richard Henderson <address@hidden> writes:
> 
>> On 04/24/2018 05:24 AM, Alex Bennée wrote:
>>> +run-%: %
>>> +   $(call quiet-command, $(QEMU) $< > $<.out, "TEST", "$< on 
>>> $(TARGET_NAME)")
>>
>> I've just had an x86_64 guest test run for 70 minutes.  We need to limit the
>> amount of time spent here in some way, with excessive time reported as test
>> failure.
>>
>> One potential way would be to add "ulimit -t $TIMEOUT" to the subshell before
>> running qemu.  A default TIMEOUT might be e.g. 15 seconds.  I'm not sure what
>> we should expect for the largest test on the smallest hosts...
> 
> Sounds reasonable - test-i386-fprem is probably the longest - I'm not
> sure it needs to be so exhaustive.

Better, not via ulimit but via something that measures wall time.  That way we
don't stall on e.g. a locked mutex when the child isn't spinning in a loop as
it was here.

I'd guess a small python script would be most maintainable...


r~