[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [RFC PATCH v2 3/7] qcow2: Implement copy o
From: |
Fam Zheng |
Subject: |
Re: [Qemu-devel] [Qemu-block] [RFC PATCH v2 3/7] qcow2: Implement copy offloading |
Date: |
Fri, 27 Apr 2018 14:28:05 +0800 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Thu, 04/26 16:34, Stefan Hajnoczi wrote:
> On Wed, Apr 18, 2018 at 11:04:20AM +0800, Fam Zheng wrote:
> > +static int qcow2_co_copy_range_to(BlockDriverState *bs,
> > + BdrvChild *src, uint64_t src_offset,
> > + BdrvChild *dst, uint64_t dst_offset,
> > + uint64_t bytes, BdrvRequestFlags flags)
> > +{
>
> In theory this could increment the refcount if src == dst. It's not
> necessary to go down to leaf nodes if the sharing can be handled at the
> qcow2 L2 table level.
Yes, this is a good optimization to have.
Fam
- [Qemu-devel] [RFC PATCH v2 0/7] qemu-img convert with copy offloading, Fam Zheng, 2018/04/17
- [Qemu-devel] [RFC PATCH v2 1/7] block: Introduce API for copy offloading, Fam Zheng, 2018/04/17
- [Qemu-devel] [RFC PATCH v2 2/7] raw: Implement copy offloading, Fam Zheng, 2018/04/17
- [Qemu-devel] [RFC PATCH v2 3/7] qcow2: Implement copy offloading, Fam Zheng, 2018/04/17
- [Qemu-devel] [RFC PATCH v2 4/7] file-posix: Implement bdrv_co_copy_range, Fam Zheng, 2018/04/17
- [Qemu-devel] [RFC PATCH v2 5/7] iscsi: Implement copy offloading, Fam Zheng, 2018/04/17
- [Qemu-devel] [RFC PATCH v2 6/7] block-backend: Add blk_co_copy_range, Fam Zheng, 2018/04/17
- [Qemu-devel] [RFC PATCH v2 7/7] qemu-img: Convert with copy offloading, Fam Zheng, 2018/04/17