Re: [Qemu-devel] [PATCH v2 4/4] qapi: discriminate CpuInfoFast on SysEmuTarget, not CpuInfoArch

[Markus Armbruster]

Laszlo Ersek <address@hidden> writes:

> Add a new field @target (of type @SysEmuTarget) to the output of the
> @query-cpus-fast command, which provides more information about the
> emulation target than the field @arch (of type @CpuInfoArch). Make @target
> the new discriminator for the @CpuInfoFast return structure. Keep @arch
> for compatibility.
>
> Cc: "Daniel P. Berrange" <address@hidden>
> Cc: Eric Blake <address@hidden>
> Cc: Markus Armbruster <address@hidden>
> Signed-off-by: Laszlo Ersek <address@hidden>
> ---
>
> Notes:
>     PATCHv2:
>     
>     - drop patch v1 5/6 with the CpuInfoCommon refactoring / extraction, as
>       @CpuInfo / @query-cpus are deprecated [Eric, Markus]
>     
>     - for the same reason, add @target to @CpuInfoFast / @query-cpus-fast
>       only [Eric, Markus]
>     
>     - Can't set @arch compatibly from a QAPI enum lookup of the proposed
>       TARGET_BASE_ARCH macro, because TARGET_BASE_ARCH=s390x is not
>       identical to the @s390 @CpuInfoArch constant -- see more at
>       <http://mid.mail-archive.com/address@hidden>.
>       Keep sysemu_target_to_cpuinfo_arch() instead. [Markus, Eric]
>     
>     - update CC list
>     
>     PATCHv1:
>     
>     - new patch
>
>  qapi/misc.json | 63 ++++++++++++++++++++++++++++++++----------
>  cpus.c         | 87 
> ++++++++++++++++++++++++++++++++++++++++++----------------
>  2 files changed, 111 insertions(+), 39 deletions(-)
>
> diff --git a/qapi/misc.json b/qapi/misc.json
> index 460866cf542f..74e5c2e3b8f7 100644
> --- a/qapi/misc.json
> +++ b/qapi/misc.json
> @@ -550,41 +550,72 @@
>  # Information about a virtual CPU
>  #
>  # @cpu-index: index of the virtual CPU
>  #
>  # @qom-path: path to the CPU object in the QOM tree
>  #
>  # @thread-id: ID of the underlying host thread
>  #
>  # @props: properties describing to which node/socket/core/thread
>  #         virtual CPU belongs to, provided if supported by board
>  #
> -# @arch: architecture of the cpu, which determines which additional fields
> -#        will be listed
> +# @arch: base architecture of the cpu

Let's deprecate this misbegotten enumeration, as I proposed in
Message-ID: <address@hidden>.  Could be done as a
follow-up patch.

> +#
> +# @target: the QEMU system emulation target, which is more specific than
> +#          @arch and determines which additional fields will be listed
> +#          (since 2.13)
> +#

May want to drop "is more specific than @arch and" then.

>  #
>  # Since: 2.12
>  #
>  ##
[...]

In case we decide not to deprecate @arch right away:
Reviewed-by: Markus Armbruster <address@hidden>