[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [RFC PATCH v2 11/19] replay: flush events when exitting
From: |
Pavel Dovgalyuk |
Subject: |
[Qemu-devel] [RFC PATCH v2 11/19] replay: flush events when exitting |
Date: |
Sat, 28 Apr 2018 15:37:31 +0300 |
User-agent: |
StGit/0.17.1-dirty |
This patch adds events processing when emulation finishes instead
of just cleaning the queue. Now the bdrv coroutines will be in consistent
state when emulator closes. It allows correct polling of the block layer
at exit.
Signed-off-by: Pavel Dovgalyuk <address@hidden>
---
replay/replay-events.c | 14 +-------------
replay/replay-internal.h | 2 --
2 files changed, 1 insertion(+), 15 deletions(-)
diff --git a/replay/replay-events.c b/replay/replay-events.c
index 707de38..0964a82 100644
--- a/replay/replay-events.c
+++ b/replay/replay-events.c
@@ -94,18 +94,6 @@ void replay_disable_events(void)
}
}
-void replay_clear_events(void)
-{
- g_assert(replay_mutex_locked());
-
- while (!QTAILQ_EMPTY(&events_list)) {
- Event *event = QTAILQ_FIRST(&events_list);
- QTAILQ_REMOVE(&events_list, event, events);
-
- g_free(event);
- }
-}
-
/*! Adds specified async event to the queue */
void replay_add_event(ReplayAsyncEventKind event_kind,
void *opaque,
@@ -308,7 +296,7 @@ void replay_init_events(void)
void replay_finish_events(void)
{
events_enabled = false;
- replay_clear_events();
+ replay_flush_events();
}
bool replay_events_enabled(void)
diff --git a/replay/replay-internal.h b/replay/replay-internal.h
index 34d19eb..a2221e5 100644
--- a/replay/replay-internal.h
+++ b/replay/replay-internal.h
@@ -148,8 +148,6 @@ void replay_init_events(void);
void replay_finish_events(void);
/*! Flushes events queue */
void replay_flush_events(void);
-/*! Clears events list before loading new VM state */
-void replay_clear_events(void);
/*! Returns true if there are any unsaved events in the queue */
bool replay_has_events(void);
/*! Saves events from queue into the file */
- [Qemu-devel] [RFC PATCH v2 01/19] block: implement bdrv_snapshot_goto for blkreplay, (continued)
- [Qemu-devel] [RFC PATCH v2 01/19] block: implement bdrv_snapshot_goto for blkreplay, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 02/19] replay: disable default snapshot for record/replay, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 04/19] replay: don't drain/flush bdrv queue while RR is working, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 03/19] replay: update docs for record/replay with block devices, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 08/19] replay: introduce info hmp/qmp command, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 06/19] qcow2: introduce icount field for snapshots, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 05/19] replay: finish record/replay before closing the disks, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 07/19] migration: introduce icount field for snapshots, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 09/19] replay: introduce breakpoint at the specified step, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 10/19] replay: implement replay-seek command to proceed to the desired step, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 11/19] replay: flush events when exitting,
Pavel Dovgalyuk <=
- [Qemu-devel] [RFC PATCH v2 12/19] timer: remove replay clock probe in deadline calculation, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 13/19] replay: refine replay-time module, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 14/19] translator: fix breakpoint processing, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 15/19] replay: flush rr queue before loading the vmstate, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 16/19] gdbstub: add reverse step support in replay mode, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 17/19] gdbstub: add reverse continue support in replay mode, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 18/19] replay: describe reverse debugging in docs/replay.txt, Pavel Dovgalyuk, 2018/04/28
- [Qemu-devel] [RFC PATCH v2 19/19] replay: allow loading any snapshots before recording, Pavel Dovgalyuk, 2018/04/28
- Re: [Qemu-devel] [RFC PATCH v2 00/19] reverse debugging, Ciro Santilli, 2018/04/30