[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v2 4/5] checkpatch: emit a warning on file add/move/
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH v2 4/5] checkpatch: emit a warning on file add/move/delete |
Date: |
Mon, 30 Apr 2018 13:46:50 +0100 |
From: Joe Perches <address@hidden>
Whenever files are added, moved, or deleted, the MAINTAINERS file
patterns can be out of sync or outdated.
To try to keep MAINTAINERS more up-to-date, add a one-time warning
whenever a patch does any of those.
Signed-off-by: Joe Perches <address@hidden>
Acked-by: Andy Whitcroft <address@hidden>
Signed-off-by: Andrew Morton <address@hidden>
Signed-off-by: Linus Torvalds <address@hidden>
(cherry picked from commit 13f1937ef33950b1112049972249e6191b82e6c9)
Signed-off-by: Stefan Hajnoczi <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
Conflicts:
QEMU WARN() only takes one argument, drop the 'type' value in the
first argument.
---
scripts/checkpatch.pl | 12 +++++++++++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 20d5b62586..84bdf53af7 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1185,7 +1185,7 @@ sub process {
my $in_header_lines = $file ? 0 : 1;
my $in_commit_log = 0; #Scanning lines before patch
-
+ my $reported_maintainer_file = 0;
my $non_utf8_charset = 0;
our @report = ();
@@ -1390,6 +1390,16 @@ sub process {
}
}
+# Check for added, moved or deleted files
+ if (!$reported_maintainer_file && !$in_commit_log &&
+ ($line =~ /^(?:new|deleted) file mode\s*\d+\s*$/ ||
+ $line =~ /^rename (?:from|to) [\w\/\.\-]+\s*$/ ||
+ ($line =~ /\{\s*([\w\/\.\-]*)\s*\=\>\s*([\w\/\.\-]*)\s*\}/
&&
+ (defined($1) || defined($2))))) {
+ $reported_maintainer_file = 1;
+ WARN("added, moved or deleted file(s), does MAINTAINERS
need updating?\n" . $herecurr);
+ }
+
# Check for wrappage within a valid hunk of the file
if ($realcnt != 0 && $line !~ m{^(?:\+|-| |\\ No newline|$)}) {
ERROR("patch seems to be corrupt (line wrapped?)\n" .
--
2.14.3
- [Qemu-devel] [PATCH v2 0/5] checkpatch: backport UTF-8 fixes and MAINTAINERS check, Stefan Hajnoczi, 2018/04/30
- [Qemu-devel] [PATCH v2 1/5] checkpatch: add a --strict check for utf-8 in commit logs, Stefan Hajnoczi, 2018/04/30
- [Qemu-devel] [PATCH v2 2/5] checkpatch: check utf-8 content from a commit log when it's missing from charset, Stefan Hajnoczi, 2018/04/30
- [Qemu-devel] [PATCH v2 3/5] checkpatch: ignore email headers better, Stefan Hajnoczi, 2018/04/30
- [Qemu-devel] [PATCH v2 4/5] checkpatch: emit a warning on file add/move/delete,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH v2 5/5] checkpatch: reduce MAINTAINERS update message frequency, Stefan Hajnoczi, 2018/04/30
- Re: [Qemu-devel] [PATCH v2 0/5] checkpatch: backport UTF-8 fixes and MAINTAINERS check, no-reply, 2018/04/30