|
| From: | Eric Blake |
| Subject: | Re: [Qemu-devel] [PATCH qemu] qom: Document qom/device-list-properties implementation specific |
| Date: | Tue, 1 May 2018 08:01:58 -0500 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 04/30/2018 01:52 AM, Alexey Kardashevskiy wrote:
Signed-off-by: Alexey Kardashevskiy <address@hidden> ---
There is no rationale in the commit body (a good commit message has a one-line summary of "what", then a paragraph stating "why", making it easier for the reviewer to check that the patch itself is the "how" that matches the commit message).
Also, when sending a new patch, it's best to send it as a new top-level thread, rather than in-reply-to an older thread that has already seen review commentary (otherwise, it's likely to get missed in the noise).
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
| [Prev in Thread] | Current Thread | [Next in Thread] |