[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC PATCH 4/7] qemu.py: Avoid deprecated tempfile.mkte
From: |
Cleber Rosa |
Subject: |
Re: [Qemu-devel] [RFC PATCH 4/7] qemu.py: Avoid deprecated tempfile.mktemp() |
Date: |
Tue, 1 May 2018 15:33:34 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 |
On 04/19/2018 12:46 PM, Philippe Mathieu-Daudé wrote:
> We already have secure temporary directory created with tempfile.mkdtemp().
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> scripts/qemu.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/scripts/qemu.py b/scripts/qemu.py
> index 379767b62f..26c4b1fd3b 100644
> --- a/scripts/qemu.py
> +++ b/scripts/qemu.py
> @@ -201,7 +201,8 @@ class QEMUMachine(object):
>
> chardev = 'socket,id=console,{address},server,nowait'
> if console_address is None:
> - console_address = tempfile.mktemp()
> + console_address = os.path.join(self._temp_dir,
> + self._name + "-console.sock")
> chardev = chardev.format(address='path=%s' %
> console_address)
> elif isinstance(console_address, tuple):
>
Acked-by: Cleber Rosa <address@hidden>
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [RFC PATCH 4/7] qemu.py: Avoid deprecated tempfile.mktemp(),
Cleber Rosa <=