qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 1/5] checkpatch: add a --strict check for utf


From: Thomas Huth
Subject: Re: [Qemu-devel] [PATCH v2 1/5] checkpatch: add a --strict check for utf-8 in commit logs
Date: Wed, 2 May 2018 07:32:12 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0

On 30.04.2018 14:46, Stefan Hajnoczi wrote:
> From: Joe Perches <address@hidden>
> 
> Some find using utf-8 in commit logs inappropriate.
> 
> Some patch commit logs contain unintended utf-8 characters when doing
> things like copy/pasting compilation output.
> 
> Look for the start of any commit log by skipping initial lines that look
> like email headers and "From: " lines.
> 
> Stop looking for utf-8 at the first signature line.
> 
> Signed-off-by: Joe Perches <address@hidden>
> Suggested-by: Andrew Morton <address@hidden>
> Cc: Andy Whitcroft <address@hidden>
> Signed-off-by: Andrew Morton <address@hidden>
> Signed-off-by: Linus Torvalds <address@hidden>
> (cherry picked from commit 15662b3e8644905032c2e26808401a487d4e90c1)
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> 
> Conflicts:
>   QEMU does not have CHK(), use WARN() instead.
> 
>   QEMU WARN() only takes one argument, drop the 'type' value in the
>   first argument.
> ---
>  scripts/checkpatch.pl | 30 ++++++++++++++++++++++++++----
>  1 file changed, 26 insertions(+), 4 deletions(-)

Reviewed-by: Thomas Huth <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]