Re: [Qemu-devel] [PATCH v6 4/5] qobject: modify qobject_ref() to return obj

[Markus Armbruster]

Eric Blake <address@hidden> writes:

> On 04/27/2018 06:42 AM, Markus Armbruster wrote:
>
>>>> +++ b/include/qapi/qmp/qobject.h
>>>> @@ -72,11 +72,12 @@ static inline void qobject_init(QObject *obj, QType 
>>>> type)
>>>>       obj->base.type = type;
>>>>   }
>>>>   -static inline void qobject_ref_impl(QObject *obj)
>>>> +static inline void *qobject_ref_impl(QObject *obj)
>>>>   {
>>>>       if (obj) {
>>>>           obj->base.refcnt++;
>>>>       }
>>>> +    return obj;
>>>
>>> This hunk is now useless,
>>>
>
>>>> -#define qobject_ref(obj) qobject_ref_impl(QOBJECT(obj))
>>>> +#define qobject_ref(obj) ({                     \
>>>> +    typeof(obj) _o = (obj);                     \
>>>> +    qobject_ref_impl(QOBJECT(_o));              \
>>>> +    _o;                                         \
>>>
>>> since nothing ever uses the return value.
>>>
>>> But that said, I'm still okay with R-b with or without the useless hunk.
>>
>> I intend to drop it on commit.
>
> It's still there on your qapi-next tree; did you forget to remove it?

Thanks for reminding me.  It's gone now.