Re: [Qemu-devel] [PATCH] migration: fix saving normal page even if it's been compressed

[Xiao Guangrong]

On 05/02/2018 10:46 AM, Peter Xu wrote:
> On Sat, Apr 28, 2018 at 04:10:45PM +0800, address@hidden wrote:
> > From: Xiao Guangrong <address@hidden>
> >
> > Fix the bug introduced by da3f56cb2e767016 (migration: remove
> > ram_save_compressed_page()), It should be 'return' rather than
> > 'res'
> >
> > Sorry for this stupid mistake :(
> >
> > Signed-off-by: Xiao Guangrong <address@hidden>
>
> Reviewed-by: Peter Xu <address@hidden>
>
> So is that only a performance degradation without this fix (since
> AFAIU the compressing pages will be sent twice)?  Thanks,

Yes, that's why we did not detect it in our test.　:(