Re: [Qemu-devel] [PATCH 05/67] migration: drop an unused include, add a used one

[Eric Blake]

On 05/03/2018 03:15 PM, Michael S. Tsirkin wrote:
> On Thu, May 03, 2018 at 03:02:59PM -0500, Eric Blake wrote:
> > On 05/03/2018 02:50 PM, Michael S. Tsirkin wrote:
> > > we just need a struct name, let's add a forward
> > > declaration instead of an include.
> >
> > Reasonable.
> >
> > > We also use size_t, so add stddef.h
> >
> > Why? osdep.h already does this, and ALL .c files that use include/ should be
> > including osdep.h prior to any other in-tree .h file.  So size_t should
> > already be in scope by the time this header is included.
>
> It seemed cleaner to have the file self-contained.
> OK, I will drop this.
> There's a small number of files which do not include qemu/osdep.h.
> Might be worth fixing.

scripts/clean-includes is already supposed to fix these.

There are a few .c files exempt from including osdep.h, but in general, 
those files should probably also not be including anything from include/.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org