[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 5/6] vfio/quirks: ioeventfd quirk acceleratio
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH v3 5/6] vfio/quirks: ioeventfd quirk acceleration |
Date: |
Fri, 4 May 2018 10:17:22 +0800 |
User-agent: |
Mutt/1.9.3 (2018-01-21) |
On Thu, May 03, 2018 at 03:45:05PM -0600, Alex Williamson wrote:
> The NVIDIA BAR0 quirks virtualize the PCI config space mirrors found
> in device MMIO space. Normally PCI config space is considered a slow
> path and further optimization is unnecessary, however NVIDIA uses a
> register here to enable the MSI interrupt to re-trigger. Exiting to
> QEMU for this MSI-ACK handling can therefore rate limit our interrupt
> handling. Fortunately the MSI-ACK write is easily detected since the
> quirk MemoryRegion otherwise has very few accesses, so simply looking
> for consecutive writes with the same data is sufficient, in this case
> 10 consecutive writes with the same data and size is arbitrarily
> chosen. We configure the KVM ioeventfd with data match, so there's
> no risk of triggering for the wrong data or size, but we do risk that
> pathological driver behavior might consume all of QEMU's file
> descriptors, so we cap ourselves to 10 ioeventfds for this purpose.
>
> In support of the above, generic ioeventfd infrastructure is added
> for vfio quirks. This automatically initializes an ioeventfd list
> per quirk, disables and frees ioeventfds on exit, and allows
> ioeventfds marked as dynamic to be dropped on device reset. The
> rationale for this latter feature is that useful ioeventfds may
> depend on specific driver behavior and since we necessarily place a
> cap on our use of ioeventfds, a machine reset is a reasonable point
> at which to assume a new driver and re-profile.
>
> Signed-off-by: Alex Williamson <address@hidden>
Reviewed-by: Peter Xu <address@hidden>
--
Peter Xu
- [Qemu-devel] [PATCH v3 0/6] vfio/quirks: ioeventfd support, Alex Williamson, 2018/05/03
- [Qemu-devel] [PATCH v3 1/6] scripts/update-linux-headers: Update handling of __aligned_u64, Alex Williamson, 2018/05/03
- [Qemu-devel] [PATCH v3 3/6] vfio/quirks: Add common quirk alloc helper, Alex Williamson, 2018/05/03
- [Qemu-devel] [PATCH v3 2/6] linux-headers: Update to v4.17-rc3, Alex Williamson, 2018/05/03
- [Qemu-devel] [PATCH v3 4/6] vfio/quirks: Add quirk reset callback, Alex Williamson, 2018/05/03
- [Qemu-devel] [PATCH v3 5/6] vfio/quirks: ioeventfd quirk acceleration, Alex Williamson, 2018/05/03
- [Qemu-devel] [PATCH v3 6/6] vfio/quirks: Enable ioeventfd quirks to be handled by vfio directly, Alex Williamson, 2018/05/03