qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 27/67] replication: add include directory header


From: Daniel P . Berrangé
Subject: Re: [Qemu-devel] [PATCH 27/67] replication: add include directory header
Date: Fri, 4 May 2018 10:29:24 +0100
User-agent: Mutt/1.9.2 (2017-12-15)

On Thu, May 03, 2018 at 10:51:05PM +0300, Michael S. Tsirkin wrote:
> This way it is easier to find using standard rules.
> 
> Signed-off-by: Michael S. Tsirkin <address@hidden>
> ---
>  include/replication.h | 1 +
>  1 file changed, 1 insertion(+)
>  create mode 100644 include/replication.h
> 
> diff --git a/include/replication.h b/include/replication.h
> new file mode 100644
> index 0000000..2f40e8e
> --- /dev/null
> +++ b/include/replication.h
> @@ -0,0 +1 @@
> +#include_next "../replication.h"

I think this is really crazy. If we want the headers to be accessible
via the include/ directory, lets move them to the include/ directory,
not create wrappers that point back to the source directory.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|



reply via email to

[Prev in Thread] Current Thread [Next in Thread]