qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 03/67] hppa: use local path for local headers


From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-devel] [PATCH 03/67] hppa: use local path for local headers
Date: Fri, 4 May 2018 13:29:43 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0

On 05/03/2018 04:50 PM, Michael S. Tsirkin wrote:
> When pulling in headers that are in the same directory as C file (as
> opposed to one in include/), we should use its relative path, without a
> directory. Directory based path works more or less by accident.
> 
> Signed-off-by: Michael S. Tsirkin <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
Tested-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>  hw/hppa/hppa_sys.h | 2 +-
>  hw/hppa/machine.c  | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/hppa/hppa_sys.h b/hw/hppa/hppa_sys.h
> index a182d1f..f98cc8d 100644
> --- a/hw/hppa/hppa_sys.h
> +++ b/hw/hppa/hppa_sys.h
> @@ -10,7 +10,7 @@
>  #include "hw/i386/pc.h"
>  #include "hw/irq.h"
>  
> -#include "hw/hppa/hppa_hardware.h"
> +#include "hppa_hardware.h"
>  
>  PCIBus *dino_init(MemoryRegion *, qemu_irq *, qemu_irq *);
>  
> diff --git a/hw/hppa/machine.c b/hw/hppa/machine.c
> index 19033e2..70f509b 100644
> --- a/hw/hppa/machine.c
> +++ b/hw/hppa/machine.c
> @@ -16,7 +16,7 @@
>  #include "hw/ide.h"
>  #include "hw/timer/i8254.h"
>  #include "hw/char/serial.h"
> -#include "hw/hppa/hppa_sys.h"
> +#include "hppa_sys.h"
>  #include "qemu/cutils.h"
>  #include "qapi/error.h"
>  #include "qemu/log.h"
> 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]