[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 6/6] migration: Stop rdma yielding during incomin
From: |
Lidong Chen |
Subject: |
[Qemu-devel] [PATCH v3 6/6] migration: Stop rdma yielding during incoming postcopy |
Date: |
Sat, 5 May 2018 22:35:36 +0800 |
During incoming postcopy, the destination qemu will invoke
qemu_rdma_wait_comp_channel in a seprate thread. So does not use rdma
yield, and poll the completion channel fd instead.
Signed-off-by: Lidong Chen <address@hidden>
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
---
migration/rdma.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/migration/rdma.c b/migration/rdma.c
index 854f355..ed9cfb1 100644
--- a/migration/rdma.c
+++ b/migration/rdma.c
@@ -1490,11 +1490,13 @@ static int qemu_rdma_wait_comp_channel(RDMAContext
*rdma)
* Coroutine doesn't start until migration_fd_process_incoming()
* so don't yield unless we know we're running inside of a coroutine.
*/
- if (rdma->migration_started_on_destination) {
+ if (rdma->migration_started_on_destination &&
+ migration_incoming_get_current()->state == MIGRATION_STATUS_ACTIVE) {
yield_until_fd_readable(rdma->comp_channel->fd);
} else {
/* This is the source side, we're in a separate thread
* or destination prior to migration_fd_process_incoming()
+ * after postcopy, the destination also in a seprate thread.
* we can't yield; so we have to poll the fd.
* But we need to be able to handle 'cancel' or an error
* without hanging forever.
--
1.8.3.1
- [Qemu-devel] [PATCH v3 0/6] Enable postcopy RDMA live migration, Lidong Chen, 2018/05/05
- [Qemu-devel] [PATCH v3 1/6] migration: disable RDMA WRITE after postcopy started, Lidong Chen, 2018/05/05
- [Qemu-devel] [PATCH v3 2/6] migration: create a dedicated connection for rdma return path, Lidong Chen, 2018/05/05
- [Qemu-devel] [PATCH v3 3/6] migration: remove unnecessary variables len in QIOChannelRDMA, Lidong Chen, 2018/05/05
- [Qemu-devel] [PATCH v3 4/6] migration: avoid concurrent invoke channel_close by different threads, Lidong Chen, 2018/05/05
- [Qemu-devel] [PATCH v3 6/6] migration: Stop rdma yielding during incoming postcopy,
Lidong Chen <=
- [Qemu-devel] [PATCH v3 5/6] migration: implement bi-directional RDMA QIOChannel, Lidong Chen, 2018/05/05