Re: [Qemu-devel] [PATCH v2 0/5] Removal of deprecated -no-kvm* options

[Markus Armbruster]

Thomas Huth <address@hidden> writes:

> On 07.05.2018 07:37, Markus Armbruster wrote:
>> Paolo Bonzini <address@hidden> writes:
>> 
>>> On 04/05/2018 19:01, Thomas Huth wrote:
>>>> The -no-kvm* options are a remainder of the ancient "qemu-kvm"
>>>> fork. They have never been officially documented in our qemu-doc,
>>>> they have been marked as deprecated in the sources since a very
>>>> long time, and we've marked them as deprecated in our qemu-doc
>>>> since QEMU v2.10. So far I haven't seen any complaints that we
>>>> should keep them, so it's time to remove these old parameters now.
>>>>
>>>> While I'm at it, this patch series also removes a left-over from
>>>> the "-tdf" option (which has been removed with QEMU v2.12) and
>>>> fixes a deficiency in the option parsing code that has been
>>>> revealed by the remainder of the "-tdf" option.
>>>>
>>>> Thomas Huth (5):
>>>>   qemu-options: Remove remainders of the -tdf option
>>>>   qemu-options: Bail out on unsupported options instead of silently
>>>>     ignoring them
>>>>   qemu-options: Remove deprecated -no-kvm-pit-reinjection
>>>>   qemu-options: Remove deprecated -no-kvm-irqchip
>>>>   qemu-options: Remove deprecated -no-kvm
>>>
>>> I'm not that sure anymore about -no-kvm.  It can come in handy for
>>> distros (*cough* RHEL *cough) that only ship a qemu-kvm binary with
>>> default accelerator "-machine accel=kvm:tcg".
>>>
>>> Yeah, "-accel tcg" is only a few characters later, but it is a
>>> relatively recent addition.
>> 
>> 2012 is "relatively recent" in the alternate RHEL universe, perhaps :)
>
> That was the "-machine accel=tcg", but Paolo was rather talking about
> "-accel tcg", which has been added last year. Yes, we've got three (!)
> ways of dealing with accelerators now: "-M accel=", "-accel" and
> "-enable-kvm + -no-kvm". We're very userfriendly, aren't we? ;-)

Ugh.  Apparently, vl.c still is a playground without adult supervision.