Re: [Qemu-devel] tpm_emu_test_wait_cond: code should not be reached

[Daniel P . Berrangé]

On Tue, May 08, 2018 at 09:41:05AM -0300, Philippe Mathieu-Daudé wrote:
> Hi,
> 
> Travis CI hit this error testing commit 853f8ca13cd6d256:
> 
> $ clang --version
> Apple LLVM version 8.1.0 (clang-802.0.42)
> Target: x86_64-apple-darwin16.7.0
> 
> $ ./configure
> C compiler        clang
> host CPU          x86_64
> ...
> TPM support       yes
> libssh2 support   no
> TPM passthrough   no
> TPM emulator      yes
> 
>   GTESTER check-qtest-i386
> Unexpected error in qio_channel_socket_readv() at io/channel-socket.c:494:
> **
> ERROR:tests/tpm-emu.c:27:tpm_emu_test_wait_cond: code should not be reached
> make: *** [check-qtest-i386] Error 1
> make: *** Waiting for unfinished jobs....

This test has a couple of threads running, and passes &error_abort to
the qio_channel_socket_readv() function. So I expect that one thread
is closing the socket connection, and the other thread has not yet
shutdown cleanly, so tries to readv on a dead socket triggering the
error_abort.  IOW,  qio_channel_socket_readv is likely just the symptom
of brokeness somewhere else in the test, not the cause.


Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|