Re: [Qemu-devel] [PATCH v1 6/7] numa: Extend the command-line to provide memory side cache information

[Eric Blake]

On 05/09/2018 03:38 AM, Liu Jingqi wrote:
> Add -numa hmat-cache option to provide Memory Side Cache Information.
> These memory attributes help to build Memory Side Cache Information
> Structure(s) in ACPI Heterogeneous Memory Attribute Table (HMAT).
>
> Signed-off-by: Liu Jingqi <address@hidden>
> ---

> +++ b/qapi/misc.json
> @@ -2705,7 +2705,7 @@
>   # Since: 2.1
>   ##
>   { 'enum': 'NumaOptionsType',
> -  'data': [ 'node', 'dist', 'cpu', 'hmat-lb' ] }
> +  'data': [ 'node', 'dist', 'cpu', 'hmat-lb', 'hmat-cache' ] }

Missing documentation.


>   ##
> +# @NumaHmatCacheOptions:
> +#
> +# Set the memory side cache information for a given memory domain.
> +#
> +# @node-id: the memory proximity domain to wich the memory belongs.

s/wich/which/

> +#
> +# @size: the size of memory side cache in bytes.
> +#
> +# @total: the total cache levels for this memory proximity domain.
> +#
> +# @level: the cache level described in this structure.
> +#
> +# @assoc: the cache associativity, none/direct(direct mapped)/complex(complex 
> cache indexing).
> +
> +# @policy: the write policy, none/wb(write back)/wt(wirte through).

No need to abbreviate; machines are just fine spitting out legible words 
like 'write-back' or 'write-through'.

s/wirte/write/

> +#
> +# @line: the cache Line size in bytes.
> +#
> +# Since: 2.10

2.13

> +##
> +{ 'struct': 'NumaHmatCacheOptions',
> +  'data': {
> +   'node-id': 'uint32',
> +   'size': 'size',
> +   'total': 'uint8',
> +   'level': 'uint8',
> +   'assoc': 'str',

Make this an enum, not an open-coded string.

> +   'policy': 'str',

Ditto.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org