[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] target/m68k: Fix build Werror with gcc 8.0.1
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH] target/m68k: Fix build Werror with gcc 8.0.1 |
Date: |
Fri, 11 May 2018 12:06:55 +0100 |
On 8 May 2018 at 21:42, Laurent Vivier <address@hidden> wrote:
> Le 08/05/2018 à 20:55, Richard Henderson a écrit :
>> Fedora 28 ships with the released gcc 8.
>>
>> The Werror stems from the compiler finding a path through the second
>> switch via a missing default case in which src1 is uninitialized, and
>> not being able to prove that the missing default case is unreachable
>> due to the first switch.
>>
>> Simplify the second switch to merge default with OS_LONG,
>> which returns directly. This removes the unreachable path.
>>
>> Cc: Laurent Vivier <address@hidden>
>> Signed-off-by: Richard Henderson <address@hidden>
>> ---
>> target/m68k/translate.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> Reviewed-by: Laurent Vivier <address@hidden>
Applied to master as a buildfix, thanks.
-- PMM