Re: [Qemu-devel] [PATCH v8 3/8] i386: Add new property to control cache info

[Eduardo Habkost]

On Thu, May 10, 2018 at 03:41:43PM -0500, Babu Moger wrote:
> The property legacy-cache will be used to control the cache information.
> If user passes "-cpu legacy-cache" then older information will
> be displayed even if the hardware supports new information. Otherwise
> use the statically loaded cache definitions if available.
> 
> Signed-off-by: Babu Moger <address@hidden>
> Tested-by: Geoffrey McRae <address@hidden>
> ---
>  include/hw/i386/pc.h |  8 ++++
>  target/i386/cpu.c    | 97 ++++++++++++++++++++++++++++++++------------
>  target/i386/cpu.h    |  5 +++
>  3 files changed, 84 insertions(+), 26 deletions(-)
> 
> diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
> index 2e834e6ded..df15deefca 100644
> --- a/include/hw/i386/pc.h
> +++ b/include/hw/i386/pc.h
> @@ -304,6 +304,14 @@ int e820_add_entry(uint64_t, uint64_t, uint32_t);
>  int e820_get_num_entries(void);
>  bool e820_get_entry(int, uint32_t, uint64_t *, uint64_t *);
>  
> +#define PC_COMPAT_2_12 \
> +    HW_COMPAT_2_12 \
> +    {\
> +        .driver   = TYPE_X86_CPU,\
> +        .property = "legacy-cache",\
> +        .value    = "on",\
> +    },

This isn't enough if the pc-*-2.12 machine-type isn't using the
macro.

Before we do this, we need a commit similar to commit
df47ce8af4a5, but adding pc-*-2.13 machine-types.

The rest of the patch looks good to me, but I will suggest a
clean up (that can be submitted a separate patch later, or
included in v9) in a separate reply.

-- 
Eduardo