Re: [Qemu-devel] [PATCH V7 00/17] COLO: integrate colo frame with block replication and COLO proxy

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH V7 00/17] COLO: integrate colo frame with block 
replication and COLO proxy

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
d4ddea2a1a COLO: quick failover process by kick COLO thread
0f2e1983ea COLO: notify net filters about checkpoint/failover event
c122b558f5 filter-rewriter: handle checkpoint and failover event
191fa37245 filter: Add handle_event method for NetFilterClass
c12e3da392 COLO: flush host dirty ram from cache
2324bc5e36 savevm: split the process of different stages for loadvm/savevm
19f435ca08 qapi: Add new command to query colo status
9fa29026c0 qmp event: Add COLO_EXIT event to notify users while exited COLO
3ec0bd3b60 COLO: Flush memory data from ram cache
445775dcd7 ram/COLO: Record the dirty pages that SVM received
f14876f270 COLO: Load dirty pages into SVM's RAM cache firstly
f03200f394 COLO: Remove colo_state migration struct
cdeb27e766 COLO: Add block replication into colo process
be854ac29e COLO: integrate colo compare with colo frame
551fe70729 colo-compare: use notifier to notify packets comparing result
6c5ccec4e6 colo-compare: implement the process of checkpoint
922a703d44 filter-rewriter: fix memory leak for connection in 
connection_track_table

=== OUTPUT BEGIN ===
Checking PATCH 1/17: filter-rewriter: fix memory leak for connection in 
connection_track_table...
Checking PATCH 2/17: colo-compare: implement the process of checkpoint...
Checking PATCH 3/17: colo-compare: use notifier to notify packets comparing 
result...
Checking PATCH 4/17: COLO: integrate colo compare with colo frame...
Checking PATCH 5/17: COLO: Add block replication into colo process...
Checking PATCH 6/17: COLO: Remove colo_state migration struct...
Checking PATCH 7/17: COLO: Load dirty pages into SVM's RAM cache firstly...
Checking PATCH 8/17: ram/COLO: Record the dirty pages that SVM received...
Checking PATCH 9/17: COLO: Flush memory data from ram cache...
Checking PATCH 10/17: qmp event: Add COLO_EXIT event to notify users while 
exited COLO...
Checking PATCH 11/17: qapi: Add new command to query colo status...
ERROR: suspect code indent for conditional statements (4, 9)
#38: FILE: migration/colo.c:250:
+    } else if (get_colo_mode() == COLO_MODE_PRIMARY) {
+         state = migrate_get_current()->state;

total: 1 errors, 0 warnings, 82 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 12/17: savevm: split the process of different stages for 
loadvm/savevm...
Checking PATCH 13/17: COLO: flush host dirty ram from cache...
Checking PATCH 14/17: filter: Add handle_event method for NetFilterClass...
Checking PATCH 15/17: filter-rewriter: handle checkpoint and failover event...
Checking PATCH 16/17: COLO: notify net filters about checkpoint/failover 
event...
Checking PATCH 17/17: COLO: quick failover process by kick COLO thread...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden