Re: [Qemu-devel] [PATCH v2 01/27] fpu/softfloat: int_to_float ensure r fully initialised

[Peter Maydell]

On 12 May 2018 at 01:42, Richard Henderson <address@hidden> wrote:
> From: Alex Bennée <address@hidden>
>
> Reported by Coverity (CID1390635). We ensure this for uint_to_float
> later on so we might as well mirror that.
>
> Signed-off-by: Alex Bennée <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  fpu/softfloat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fpu/softfloat.c b/fpu/softfloat.c
> index 8401b37bd4..b39c0c6fbb 100644
> --- a/fpu/softfloat.c
> +++ b/fpu/softfloat.c
> @@ -1525,7 +1525,7 @@ FLOAT_TO_UINT(64, 64)
>
>  static FloatParts int_to_float(int64_t a, float_status *status)
>  {
> -    FloatParts r;
> +    FloatParts r = {};
>      if (a == 0) {
>          r.cls = float_class_zero;
>          r.sign = false;
> --
> 2.17.0
>

Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM