Re: [Qemu-devel] [PATCH v7 2/2] Add QTest testcase for the Intel Hexadecimal Object File Loader.

[Stefan Hajnoczi]

On Mon, May 14, 2018 at 08:57:48AM +0200, Steffen Görtz wrote:
> On 10.05.2018 09:18, Su Hang wrote:
> > +
> > +    QTestState *s = qtest_startf(
> > +        "-M versatilepb -m 128M -nographic -kernel 
> > ../tests/hex-loader-check-data/test.hex");
> > +
> 
> The test binary "text.hex" is not being copied to out-of-tree builds at
> the moment and the test run will therefore fail.
> The acpi tests also use a fixture (acpi-test-data) which is being copied
> to the out-of-tree build in ./configure:L7181 .
> This might also be an option for your test.

To explain how out-of-tree builds work for anyone who hasn't seen them
before:

  $ mkdir /var/tmp/build-dir
  $ cd /var/tmp/build-dir
  $ ~/qemu/configure ... && make

The .o files and other build output will be located in
/var/tmp/build-dir (away from the source code in ~/qemu/).

The build system must ensure that data files are available to the test
program in /var/tmp/build-dir/ if an out-of-tree build is being done.
In the acpi-test-data case that Steffen mentioned the ./configure script
sets up symlinks:

  for test_file in $(find $source_path/tests/acpi-test-data -type f)
  do
      FILES="$FILES tests/acpi-test-data$(echo $test_file | sed -e 
's/.*acpi-test-data//')"
  done
  ...
  symlink "$source_path/$f" "$f"

Please add hex-loader-check-data in the same way.

Stefan

signature.asc
Description: PGP signature