Re: [Qemu-devel] [PATCH] linux-user: update comments to point to cpu_create()

[Laurent Vivier]

Le 15/05/2018 à 13:17, Igor Mammedov a écrit :
> cpu_init() was replaced by cpu_create() since 2.12 but comments
> weren't updated. So update stale comments now.
> 
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
>  bsd-user/main.c   | 2 +-
>  linux-user/main.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/bsd-user/main.c b/bsd-user/main.c
> index 283dc6f..a6ef4a7 100644
> --- a/bsd-user/main.c
> +++ b/bsd-user/main.c
> @@ -917,7 +917,7 @@ int main(int argc, char **argv)
>      envlist_free(envlist);
>  
>      /*
> -     * Now that page sizes are configured in cpu_init() we can do
> +     * Now that page sizes are configured in cpu_create() we can do
>       * proper page alignment for guest_base.
>       */
>      guest_base = HOST_PAGE_ALIGN(guest_base);
> diff --git a/linux-user/main.c b/linux-user/main.c
> index 3234754..27d0b37 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -693,7 +693,7 @@ int main(int argc, char **argv, char **envp)
>      envlist_free(envlist);
>  
>      /*
> -     * Now that page sizes are configured in cpu_init() we can do
> +     * Now that page sizes are configured in cpu_create() we can do
>       * proper page alignment for guest_base.
>       */
>      guest_base = HOST_PAGE_ALIGN(guest_base);
> 

I think page size is now configured in tcg_exec_init() since:

  commit 26a5f13b8eb1281d0552fe323e869806f3cefbfb
  Author: bellard <address@hidden>
  Date:   Wed May 28 12:30:31 2008 +0000

      variable dynamic translation buffer size

Strangely comment has been added after this change by:

  commit 379f6698d73f476de38682b3ff96ecb226728c43
  Author: Paul Brook <address@hidden>
  Date:   Fri Jul 17 12:48:08 2009 +0100

    Userspace guest address offsetting


Thanks,
Laurent