Re: [Qemu-devel] [PATCH v5 09/28] target/arm: Use floatX_silence_nan when we have already checked for SNaN

[Alex Bennée]

Richard Henderson <address@hidden> writes:

> Reviewed-by: Peter Maydell <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>

Reviewed-by: Alex Bennée <address@hidden>

> ---
>  target/arm/helper-a64.c |  6 +++---
>  target/arm/helper.c     | 12 ++++++------
>  2 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/target/arm/helper-a64.c b/target/arm/helper-a64.c
> index 4f8034c513..6f0eb83661 100644
> --- a/target/arm/helper-a64.c
> +++ b/target/arm/helper-a64.c
> @@ -376,7 +376,7 @@ float16 HELPER(frecpx_f16)(float16 a, void *fpstp)
>          float16 nan = a;
>          if (float16_is_signaling_nan(a, fpst)) {
>              float_raise(float_flag_invalid, fpst);
> -            nan = float16_maybe_silence_nan(a, fpst);
> +            nan = float16_silence_nan(a, fpst);
>          }
>          if (fpst->default_nan_mode) {
>              nan = float16_default_nan(fpst);
> @@ -405,7 +405,7 @@ float32 HELPER(frecpx_f32)(float32 a, void *fpstp)
>          float32 nan = a;
>          if (float32_is_signaling_nan(a, fpst)) {
>              float_raise(float_flag_invalid, fpst);
> -            nan = float32_maybe_silence_nan(a, fpst);
> +            nan = float32_silence_nan(a, fpst);
>          }
>          if (fpst->default_nan_mode) {
>              nan = float32_default_nan(fpst);
> @@ -434,7 +434,7 @@ float64 HELPER(frecpx_f64)(float64 a, void *fpstp)
>          float64 nan = a;
>          if (float64_is_signaling_nan(a, fpst)) {
>              float_raise(float_flag_invalid, fpst);
> -            nan = float64_maybe_silence_nan(a, fpst);
> +            nan = float64_silence_nan(a, fpst);
>          }
>          if (fpst->default_nan_mode) {
>              nan = float64_default_nan(fpst);
> diff --git a/target/arm/helper.c b/target/arm/helper.c
> index c6fd7f9479..3df5cf30e4 100644
> --- a/target/arm/helper.c
> +++ b/target/arm/helper.c
> @@ -11739,7 +11739,7 @@ float16 HELPER(recpe_f16)(float16 input, void *fpstp)
>          float16 nan = f16;
>          if (float16_is_signaling_nan(f16, fpst)) {
>              float_raise(float_flag_invalid, fpst);
> -            nan = float16_maybe_silence_nan(f16, fpst);
> +            nan = float16_silence_nan(f16, fpst);
>          }
>          if (fpst->default_nan_mode) {
>              nan =  float16_default_nan(fpst);
> @@ -11787,7 +11787,7 @@ float32 HELPER(recpe_f32)(float32 input, void *fpstp)
>          float32 nan = f32;
>          if (float32_is_signaling_nan(f32, fpst)) {
>              float_raise(float_flag_invalid, fpst);
> -            nan = float32_maybe_silence_nan(f32, fpst);
> +            nan = float32_silence_nan(f32, fpst);
>          }
>          if (fpst->default_nan_mode) {
>              nan =  float32_default_nan(fpst);
> @@ -11835,7 +11835,7 @@ float64 HELPER(recpe_f64)(float64 input, void *fpstp)
>          float64 nan = f64;
>          if (float64_is_signaling_nan(f64, fpst)) {
>              float_raise(float_flag_invalid, fpst);
> -            nan = float64_maybe_silence_nan(f64, fpst);
> +            nan = float64_silence_nan(f64, fpst);
>          }
>          if (fpst->default_nan_mode) {
>              nan =  float64_default_nan(fpst);
> @@ -11934,7 +11934,7 @@ float16 HELPER(rsqrte_f16)(float16 input, void *fpstp)
>          float16 nan = f16;
>          if (float16_is_signaling_nan(f16, s)) {
>              float_raise(float_flag_invalid, s);
> -            nan = float16_maybe_silence_nan(f16, s);
> +            nan = float16_silence_nan(f16, s);
>          }
>          if (s->default_nan_mode) {
>              nan =  float16_default_nan(s);
> @@ -11978,7 +11978,7 @@ float32 HELPER(rsqrte_f32)(float32 input, void *fpstp)
>          float32 nan = f32;
>          if (float32_is_signaling_nan(f32, s)) {
>              float_raise(float_flag_invalid, s);
> -            nan = float32_maybe_silence_nan(f32, s);
> +            nan = float32_silence_nan(f32, s);
>          }
>          if (s->default_nan_mode) {
>              nan =  float32_default_nan(s);
> @@ -12021,7 +12021,7 @@ float64 HELPER(rsqrte_f64)(float64 input, void *fpstp)
>          float64 nan = f64;
>          if (float64_is_signaling_nan(f64, s)) {
>              float_raise(float_flag_invalid, s);
> -            nan = float64_maybe_silence_nan(f64, s);
> +            nan = float64_silence_nan(f64, s);
>          }
>          if (s->default_nan_mode) {
>              nan =  float64_default_nan(s);


--
Alex Bennée