Re: [Qemu-devel] [PATCH] configure: Use strings command from cross development tools

[Peter Maydell]

On 15 May 2018 at 16:00, Eric Blake <address@hidden> wrote:
> On 05/13/2018 03:50 AM, Stefan Weil wrote:
>>
>> This fixes cross builds for the (rare) case where cross binutils
>> but no native binutils are installed.
>>
>> Signed-off-by: Stefan Weil <address@hidden>
>> ---
>>   configure | 5 +++--
>>   1 file changed, 3 insertions(+), 2 deletions(-)
>>
>
>> +strings="${STRINGS-${cross_prefix}strings}"
>>   strip="${STRIP-${cross_prefix}strip}"
>
>
> Hmm - we have pre-existing problems in our configure file.  More on that
> below...
>
>>   windres="${WINDRES-${cross_prefix}windres}"
>>   pkg_config_exe="${PKG_CONFIG-${cross_prefix}pkg-config}"
>> @@ -1956,9 +1957,9 @@ int main(int argc, char *argv[]) {
>>   EOF
>>     if compile_object ; then
>> -    if strings -a $TMPO | grep -q BiGeNdIaN ; then
>> +    if "$strings" -a $TMPO | grep -q BiGeNdIaN ; then
>
>
> I'd much prefer this to be:
>
> if $strings -a $TMPO | grep...
>
> That's because if I have something like this in my environment:
>
> STRINGS='/path/to/strings -a'
>
> it will only work if you allow word splitting on my variable.

Conversely, if I have STRINGS='/path with spaces/to/strings'
in my environment it will only work if you don't do word
splitting on it :-)

thanks
-- PMM