Re: [Qemu-devel] [PULL 2/4] net: Remove the deprecated "vlan" parameter

[Eric Blake]

On 05/14/2018 02:55 AM, Jason Wang wrote:
> From: Thomas Huth <address@hidden>
>
> It's been marked as deprecated since QEMU v2.9.0, so that should have
> been enough time for everybody to either just drop unnecessary "vlan=0"
> parameters, to switch to the modern -device + -netdev syntax for connecting
> guest NICs with host network backends, or to switch to the "hubport" netdev
> in case hubs are really wanted instead.
>
> Buglink: https://bugs.launchpad.net/qemu/+bug/658904
> Signed-off-by: Thomas Huth <address@hidden>
> Reviewed-by: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Jason Wang <address@hidden>
> ---

> @@ -499,10 +497,11 @@
>   # @opts: device type specific properties (legacy)
>   #
>   # Since: 1.2
> +#
> +# 'vlan' - removed with 2.12

Shouldn't this be 2.13?  Also, while the phrase 'removed with XXX' 
already appears for NetClientDriver::dump, it sounds awkward; better 
would be matching the way we document things for BlockDeviceInfo:

NetClientDriver
2.12: dropped 'dump'
...
NetLegacy
2.13: dropped 'vlan'

or the way we do it for QKeyCode:

NetClientDriver
dump: dropped in 2.12
...
NetLegacy
vlan: dropped in 2.13

As this is already in a pull request, and as NetClientDriver also needs 
a cleanup, that can be a followup patch.

--
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org