[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v6 01/28] fpu/softfloat: Fix conversion from uint64
From: |
Richard Henderson |
Subject: |
[Qemu-devel] [PATCH v6 01/28] fpu/softfloat: Fix conversion from uint64 to float128 |
Date: |
Tue, 15 May 2018 15:25:13 -0700 |
From: Petr Tesarik <address@hidden>
The significand is passed to normalizeRoundAndPackFloat128() as high
first, low second. The current code passes the integer first, so the
result is incorrectly shifted left by 64 bits.
This bug affects the emulation of s390x instruction CXLGBR (convert
from logical 64-bit binary-integer operand to extended BFP result).
Cc: address@hidden
Tested-by: Alex Bennée <address@hidden>
Reviewed-by: Alex Bennée <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
Signed-off-by: Petr Tesarik <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Richard Henderson <address@hidden>
---
fpu/softfloat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fpu/softfloat.c b/fpu/softfloat.c
index bc0f52fa54..d07419324a 100644
--- a/fpu/softfloat.c
+++ b/fpu/softfloat.c
@@ -3147,7 +3147,7 @@ float128 uint64_to_float128(uint64_t a, float_status
*status)
if (a == 0) {
return float128_zero;
}
- return normalizeRoundAndPackFloat128(0, 0x406E, a, 0, status);
+ return normalizeRoundAndPackFloat128(0, 0x406E, 0, a, status);
}
--
2.17.0
- [Qemu-devel] [PATCH v6 00/28] softfloat patch roundup, Richard Henderson, 2018/05/15
- [Qemu-devel] [PATCH v6 01/28] fpu/softfloat: Fix conversion from uint64 to float128,
Richard Henderson <=
- [Qemu-devel] [PATCH v6 02/28] fpu/softfloat: Merge NO_SIGNALING_NANS definitions, Richard Henderson, 2018/05/15
- [Qemu-devel] [PATCH v6 04/28] fpu/softfloat: Move softfloat-specialize.h below FloatParts definition, Richard Henderson, 2018/05/15
- [Qemu-devel] [PATCH v6 03/28] fpu/softfloat: Split floatXX_silence_nan from floatXX_maybe_silence_nan, Richard Henderson, 2018/05/15
- [Qemu-devel] [PATCH v6 05/28] fpu/softfloat: Canonicalize NaN fraction, Richard Henderson, 2018/05/15
- [Qemu-devel] [PATCH v6 07/28] fpu/softfloat: Replace float_class_dnan with parts_default_nan, Richard Henderson, 2018/05/15
- [Qemu-devel] [PATCH v6 06/28] fpu/softfloat: Introduce parts_is_snan_frac, Richard Henderson, 2018/05/15
- [Qemu-devel] [PATCH v6 10/28] target/arm: squash FZ16 behaviour for conversions, Richard Henderson, 2018/05/15
- [Qemu-devel] [PATCH v6 08/28] fpu/softfloat: Replace float_class_msnan with parts_silence_nan, Richard Henderson, 2018/05/15
- [Qemu-devel] [PATCH v6 11/28] fpu/softfloat: Partial support for ARM Alternative half-precision, Richard Henderson, 2018/05/15
- [Qemu-devel] [PATCH v6 09/28] target/arm: convert conversion helpers to fpst/ahp_flag, Richard Henderson, 2018/05/15