[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/4] display: add new bochs-display device
From: |
no-reply |
Subject: |
Re: [Qemu-devel] [PATCH 0/4] display: add new bochs-display device |
Date: |
Thu, 17 May 2018 02:32:49 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 0/4] display: add new bochs-display device
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
110b775813 bochs-display: add pcie support
1e7d025590 bochs-display: add dirty tracking support
ab5e478d06 display: add new bochs-display device
149c738fb9 vga: move bochs vbe defines to header file
=== OUTPUT BEGIN ===
Checking PATCH 1/4: vga: move bochs vbe defines to header file...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#86:
new file mode 100644
total: 0 errors, 1 warnings, 127 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/4: display: add new bochs-display device...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#43:
new file mode 100644
ERROR: braces {} are necessary for all arms of this statement
#199: FILE: hw/display/bochs-display.c:152:
+ if (!(vbe[VBE_DISPI_INDEX_ENABLE] & VBE_DISPI_ENABLED))
[...]
WARNING: line over 80 characters
#209: FILE: hw/display/bochs-display.c:162:
+ mode->format = s->big_endian_fb ? PIXMAN_BE_x8r8g8b8 :
PIXMAN_LE_x8r8g8b8;
ERROR: braces {} are necessary for all arms of this statement
#219: FILE: hw/display/bochs-display.c:172:
+ if (virt_width < mode->width)
[...]
WARNING: line over 80 characters
#309: FILE: hw/display/bochs-display.c:262:
+static void bochs_display_set_big_endian_fb(Object *obj, bool value, Error
**errp)
total: 2 errors, 3 warnings, 330 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 3/4: bochs-display: add dirty tracking support...
WARNING: line over 80 characters
#44: FILE: hw/display/bochs-display.c:231:
+ mode.offset + mode.stride
* y,
total: 0 errors, 1 warnings, 56 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 4/4: bochs-display: add pcie support...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden
- [Qemu-devel] [PATCH 3/4] bochs-display: add dirty tracking support, (continued)