Re: [Qemu-devel] [PULL 09/28] target/arm: convert conversion helpers to fpst/ahp_flag

[Richard Henderson]

On 05/17/2018 03:16 AM, Peter Maydell wrote:
> On 16 May 2018 at 16:52, Richard Henderson <address@hidden> wrote:
>> diff --git a/target/arm/translate.c b/target/arm/translate.c
>> index 731cf327a1..613598d090 100644
>> --- a/target/arm/translate.c
>> +++ b/target/arm/translate.c
> 
> Just noticed, but in the 32-bit translator where the argument to
> get_fpstatus_ptr() is "is this neon?" (ie "do we use the standard
> FPSCR value"), shouldn't we be passing 'true' to get_fpstatus_ptr()
> for the halfprec conversions in disas_neon_data_insn() ?

Bah.  I went overboard with the aa64 fixups and forgot that aa32 hasn't had the
real fp16 extensions added.  I'll re-send.


r~