[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] cirrus: format code
|
From: |
no-reply |
|
Subject: |
Re: [Qemu-devel] [PATCH] cirrus: format code |
|
Date: |
Sat, 19 May 2018 04:23:42 -0700 (PDT) |
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH] cirrus: format code
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
3c6433c293 cirrus: format code
=== OUTPUT BEGIN ===
Checking PATCH 1/1: cirrus: format code...
ERROR: do not use C99 // comments
#20: FILE: hw/display/cirrus_vga.c:79:
+#define CIRRUS_MEMFLAGS_BANKSWITCH 0x80 // bank switching is enabled.
ERROR: do not use C99 // comments
#26: FILE: hw/display/cirrus_vga.c:84:
+#define CIRRUS_CURSOR_LARGE 0x04 // 64x64 if set, 32x32 if clear
ERROR: do not use C99 // comments
#35: FILE: hw/display/cirrus_vga.c:92:
+#define CIRRUS_MMIO_USE_PCIADDR 0x40 // 0xb8000 if cleared.
ERROR: do not use C99 // comments
#41: FILE: hw/display/cirrus_vga.c:97:
+#define CIRRUS_BANKING_GRANULARITY_16K 0x20 // set:16k, clear:4k
ERROR: do not use C99 // comments
#78: FILE: hw/display/cirrus_vga.c:146:
+#define CIRRUS_MMIO_BLTBGCOLOR 0x00 // dword
ERROR: do not use C99 // comments
#79: FILE: hw/display/cirrus_vga.c:147:
+#define CIRRUS_MMIO_BLTFGCOLOR 0x04 // dword
ERROR: do not use C99 // comments
#80: FILE: hw/display/cirrus_vga.c:148:
+#define CIRRUS_MMIO_BLTWIDTH 0x08 // word
ERROR: do not use C99 // comments
#81: FILE: hw/display/cirrus_vga.c:149:
+#define CIRRUS_MMIO_BLTHEIGHT 0x0a // word
ERROR: do not use C99 // comments
#82: FILE: hw/display/cirrus_vga.c:150:
+#define CIRRUS_MMIO_BLTDESTPITCH 0x0c // word
ERROR: do not use C99 // comments
#83: FILE: hw/display/cirrus_vga.c:151:
+#define CIRRUS_MMIO_BLTSRCPITCH 0x0e // word
ERROR: do not use C99 // comments
#84: FILE: hw/display/cirrus_vga.c:152:
+#define CIRRUS_MMIO_BLTDESTADDR 0x10 // dword
ERROR: do not use C99 // comments
#85: FILE: hw/display/cirrus_vga.c:153:
+#define CIRRUS_MMIO_BLTSRCADDR 0x14 // dword
ERROR: do not use C99 // comments
#86: FILE: hw/display/cirrus_vga.c:154:
+#define CIRRUS_MMIO_BLTWRITEMASK 0x17 // byte
ERROR: do not use C99 // comments
#87: FILE: hw/display/cirrus_vga.c:155:
+#define CIRRUS_MMIO_BLTMODE 0x18 // byte
ERROR: do not use C99 // comments
#88: FILE: hw/display/cirrus_vga.c:156:
+#define CIRRUS_MMIO_BLTROP 0x1a // byte
ERROR: do not use C99 // comments
#89: FILE: hw/display/cirrus_vga.c:157:
+#define CIRRUS_MMIO_BLTMODEEXT 0x1b // byte
ERROR: do not use C99 // comments
#90: FILE: hw/display/cirrus_vga.c:158:
+#define CIRRUS_MMIO_BLTTRANSPARENTCOLOR 0x1c // word?
ERROR: do not use C99 // comments
#91: FILE: hw/display/cirrus_vga.c:159:
+#define CIRRUS_MMIO_BLTTRANSPARENTCOLORMASK 0x20 // word?
ERROR: do not use C99 // comments
#92: FILE: hw/display/cirrus_vga.c:160:
+#define CIRRUS_MMIO_LINEARDRAW_START_X 0x24 // word
ERROR: do not use C99 // comments
#93: FILE: hw/display/cirrus_vga.c:161:
+#define CIRRUS_MMIO_LINEARDRAW_START_Y 0x26 // word
ERROR: do not use C99 // comments
#94: FILE: hw/display/cirrus_vga.c:162:
+#define CIRRUS_MMIO_LINEARDRAW_END_X 0x28 // word
ERROR: do not use C99 // comments
#95: FILE: hw/display/cirrus_vga.c:163:
+#define CIRRUS_MMIO_LINEARDRAW_END_Y 0x2a // word
ERROR: do not use C99 // comments
#96: FILE: hw/display/cirrus_vga.c:164:
+#define CIRRUS_MMIO_LINEARDRAW_LINESTYLE_INC 0x2c // byte
ERROR: do not use C99 // comments
#97: FILE: hw/display/cirrus_vga.c:165:
+#define CIRRUS_MMIO_LINEARDRAW_LINESTYLE_ROLLOVER 0x2d // byte
ERROR: do not use C99 // comments
#98: FILE: hw/display/cirrus_vga.c:166:
+#define CIRRUS_MMIO_LINEARDRAW_LINESTYLE_MASK 0x2e // byte
ERROR: do not use C99 // comments
#99: FILE: hw/display/cirrus_vga.c:167:
+#define CIRRUS_MMIO_LINEARDRAW_LINESTYLE_ACCUM 0x2f // byte
ERROR: do not use C99 // comments
#100: FILE: hw/display/cirrus_vga.c:168:
+#define CIRRUS_MMIO_BRESENHAM_K1 0x30 // word
ERROR: do not use C99 // comments
#101: FILE: hw/display/cirrus_vga.c:169:
+#define CIRRUS_MMIO_BRESENHAM_K3 0x32 // word
ERROR: do not use C99 // comments
#102: FILE: hw/display/cirrus_vga.c:170:
+#define CIRRUS_MMIO_BRESENHAM_ERROR 0x34 // word
ERROR: do not use C99 // comments
#103: FILE: hw/display/cirrus_vga.c:171:
+#define CIRRUS_MMIO_BRESENHAM_DELTA_MAJOR 0x36 // word
ERROR: do not use C99 // comments
#104: FILE: hw/display/cirrus_vga.c:172:
+#define CIRRUS_MMIO_BRESENHAM_DIRECTION 0x38 // byte
ERROR: do not use C99 // comments
#105: FILE: hw/display/cirrus_vga.c:173:
+#define CIRRUS_MMIO_LINEDRAW_MODE 0x39 // byte
ERROR: do not use C99 // comments
#106: FILE: hw/display/cirrus_vga.c:174:
+#define CIRRUS_MMIO_BLTSTATUS 0x40 // byte
WARNING: line over 80 characters
#313: FILE: hw/display/cirrus_vga.c:1107:
+ printf("src transparent without colorexpand must be 8bpp
or 16bpp\n");
ERROR: line over 90 characters
#319: FILE: hw/display/cirrus_vga.c:1113:
+ s->cirrus_rop =
cirrus_bkwd_transp_rop[rop_to_index[blt_rop]][s->cirrus_blt_pixelwidth - 1];
ERROR: line over 90 characters
#321: FILE: hw/display/cirrus_vga.c:1115:
+ s->cirrus_rop =
cirrus_fwd_transp_rop[rop_to_index[blt_rop]][s->cirrus_blt_pixelwidth - 1];
ERROR: do not use C99 // comments
#525: FILE: hw/display/cirrus_vga.c:1322:
+ case 0x00: // Standard VGA
ERROR: do not use C99 // comments
#526: FILE: hw/display/cirrus_vga.c:1323:
+ case 0x01: // Standard VGA
ERROR: do not use C99 // comments
#527: FILE: hw/display/cirrus_vga.c:1324:
+ case 0x02: // Standard VGA
ERROR: do not use C99 // comments
#528: FILE: hw/display/cirrus_vga.c:1325:
+ case 0x03: // Standard VGA
ERROR: do not use C99 // comments
#529: FILE: hw/display/cirrus_vga.c:1326:
+ case 0x04: // Standard VGA
ERROR: do not use C99 // comments
#531: FILE: hw/display/cirrus_vga.c:1328:
+ case 0x06: // Unlock Cirrus extensions
ERROR: do not use C99 // comments
#537: FILE: hw/display/cirrus_vga.c:1333:
+ case 0x70: // Graphics Cursor X
ERROR: do not use C99 // comments
#543: FILE: hw/display/cirrus_vga.c:1337:
+ case 0xf0: // Graphics Cursor X
ERROR: do not use C99 // comments
#549: FILE: hw/display/cirrus_vga.c:1342:
+ case 0x71: // Graphics Cursor Y
ERROR: do not use C99 // comments
#579: FILE: hw/display/cirrus_vga.c:1346:
+ case 0xf1: // Graphics Cursor Y
ERROR: do not use C99 // comments
#581: FILE: hw/display/cirrus_vga.c:1348:
+ case 0x05: // ???
ERROR: do not use C99 // comments
#582: FILE: hw/display/cirrus_vga.c:1349:
+ case 0x07: // Extended Sequencer Mode
ERROR: do not use C99 // comments
#583: FILE: hw/display/cirrus_vga.c:1350:
+ case 0x08: // EEPROM Control
ERROR: do not use C99 // comments
#584: FILE: hw/display/cirrus_vga.c:1351:
+ case 0x09: // Scratch Register 0
ERROR: do not use C99 // comments
#585: FILE: hw/display/cirrus_vga.c:1352:
+ case 0x0a: // Scratch Register 1
ERROR: do not use C99 // comments
#586: FILE: hw/display/cirrus_vga.c:1353:
+ case 0x0b: // VCLK 0
ERROR: do not use C99 // comments
#587: FILE: hw/display/cirrus_vga.c:1354:
+ case 0x0c: // VCLK 1
ERROR: do not use C99 // comments
#588: FILE: hw/display/cirrus_vga.c:1355:
+ case 0x0d: // VCLK 2
ERROR: do not use C99 // comments
#589: FILE: hw/display/cirrus_vga.c:1356:
+ case 0x0e: // VCLK 3
ERROR: do not use C99 // comments
#590: FILE: hw/display/cirrus_vga.c:1357:
+ case 0x0f: // DRAM Control
ERROR: do not use C99 // comments
#591: FILE: hw/display/cirrus_vga.c:1358:
+ case 0x12: // Graphics Cursor Attribute
ERROR: do not use C99 // comments
#592: FILE: hw/display/cirrus_vga.c:1359:
+ case 0x13: // Graphics Cursor Pattern Address
ERROR: do not use C99 // comments
#593: FILE: hw/display/cirrus_vga.c:1360:
+ case 0x14: // Scratch Register 2
ERROR: do not use C99 // comments
#594: FILE: hw/display/cirrus_vga.c:1361:
+ case 0x15: // Scratch Register 3
ERROR: do not use C99 // comments
#595: FILE: hw/display/cirrus_vga.c:1362:
+ case 0x16: // Performance Tuning Register
WARNING: line over 80 characters
#596: FILE: hw/display/cirrus_vga.c:1363:
+ case 0x17: // Configuration Readback and Extended
Control
ERROR: do not use C99 // comments
#596: FILE: hw/display/cirrus_vga.c:1363:
+ case 0x17: // Configuration Readback and Extended
Control
ERROR: do not use C99 // comments
#597: FILE: hw/display/cirrus_vga.c:1364:
+ case 0x18: // Signature Generator Control
ERROR: do not use C99 // comments
#598: FILE: hw/display/cirrus_vga.c:1365:
+ case 0x19: // Signal Generator Result
ERROR: do not use C99 // comments
#599: FILE: hw/display/cirrus_vga.c:1366:
+ case 0x1a: // Signal Generator Result
ERROR: do not use C99 // comments
#600: FILE: hw/display/cirrus_vga.c:1367:
+ case 0x1b: // VCLK 0 Denominator & Post
ERROR: do not use C99 // comments
#601: FILE: hw/display/cirrus_vga.c:1368:
+ case 0x1c: // VCLK 1 Denominator & Post
ERROR: do not use C99 // comments
#602: FILE: hw/display/cirrus_vga.c:1369:
+ case 0x1d: // VCLK 2 Denominator & Post
ERROR: do not use C99 // comments
#603: FILE: hw/display/cirrus_vga.c:1370:
+ case 0x1e: // VCLK 3 Denominator & Post
ERROR: do not use C99 // comments
#604: FILE: hw/display/cirrus_vga.c:1371:
+ case 0x1f: // BIOS Write Enable and MCLK select
ERROR: do not use C99 // comments
#633: FILE: hw/display/cirrus_vga.c:1388:
+ case 0x00: // Standard VGA
ERROR: do not use C99 // comments
#634: FILE: hw/display/cirrus_vga.c:1389:
+ case 0x01: // Standard VGA
ERROR: do not use C99 // comments
#635: FILE: hw/display/cirrus_vga.c:1390:
+ case 0x02: // Standard VGA
ERROR: do not use C99 // comments
#636: FILE: hw/display/cirrus_vga.c:1391:
+ case 0x03: // Standard VGA
ERROR: do not use C99 // comments
#637: FILE: hw/display/cirrus_vga.c:1392:
+ case 0x04: // Standard VGA
ERROR: braces {} are necessary for all arms of this statement
#639: FILE: hw/display/cirrus_vga.c:1394:
+ if (s->vga.sr_index == 1)
[...]
ERROR: do not use C99 // comments
#650: FILE: hw/display/cirrus_vga.c:1397:
+ case 0x06: // Unlock Cirrus extensions
ERROR: do not use C99 // comments
#662: FILE: hw/display/cirrus_vga.c:1408:
+ case 0x70: // Graphics Cursor X
ERROR: do not use C99 // comments
#668: FILE: hw/display/cirrus_vga.c:1412:
+ case 0xf0: // Graphics Cursor X
ERROR: do not use C99 // comments
#677: FILE: hw/display/cirrus_vga.c:1419:
+ case 0x71: // Graphics Cursor Y
ERROR: do not use C99 // comments
#683: FILE: hw/display/cirrus_vga.c:1423:
+ case 0xf1: // Graphics Cursor Y
ERROR: do not use C99 // comments
#711: FILE: hw/display/cirrus_vga.c:1427:
+ case 0x07: // Extended Sequencer Mode
ERROR: do not use C99 // comments
#713: FILE: hw/display/cirrus_vga.c:1429:
+ case 0x08: // EEPROM Control
ERROR: do not use C99 // comments
#714: FILE: hw/display/cirrus_vga.c:1430:
+ case 0x09: // Scratch Register 0
ERROR: do not use C99 // comments
#715: FILE: hw/display/cirrus_vga.c:1431:
+ case 0x0a: // Scratch Register 1
ERROR: do not use C99 // comments
#716: FILE: hw/display/cirrus_vga.c:1432:
+ case 0x0b: // VCLK 0
ERROR: do not use C99 // comments
#717: FILE: hw/display/cirrus_vga.c:1433:
+ case 0x0c: // VCLK 1
ERROR: do not use C99 // comments
#718: FILE: hw/display/cirrus_vga.c:1434:
+ case 0x0d: // VCLK 2
ERROR: do not use C99 // comments
#719: FILE: hw/display/cirrus_vga.c:1435:
+ case 0x0e: // VCLK 3
ERROR: do not use C99 // comments
#720: FILE: hw/display/cirrus_vga.c:1436:
+ case 0x0f: // DRAM Control
ERROR: do not use C99 // comments
#721: FILE: hw/display/cirrus_vga.c:1437:
+ case 0x13: // Graphics Cursor Pattern Address
ERROR: do not use C99 // comments
#722: FILE: hw/display/cirrus_vga.c:1438:
+ case 0x14: // Scratch Register 2
ERROR: do not use C99 // comments
#723: FILE: hw/display/cirrus_vga.c:1439:
+ case 0x15: // Scratch Register 3
ERROR: do not use C99 // comments
#724: FILE: hw/display/cirrus_vga.c:1440:
+ case 0x16: // Performance Tuning Register
ERROR: do not use C99 // comments
#725: FILE: hw/display/cirrus_vga.c:1441:
+ case 0x18: // Signature Generator Control
ERROR: do not use C99 // comments
#726: FILE: hw/display/cirrus_vga.c:1442:
+ case 0x19: // Signature Generator Result
ERROR: do not use C99 // comments
#727: FILE: hw/display/cirrus_vga.c:1443:
+ case 0x1a: // Signature Generator Result
ERROR: do not use C99 // comments
#728: FILE: hw/display/cirrus_vga.c:1444:
+ case 0x1b: // VCLK 0 Denominator & Post
ERROR: do not use C99 // comments
#729: FILE: hw/display/cirrus_vga.c:1445:
+ case 0x1c: // VCLK 1 Denominator & Post
ERROR: do not use C99 // comments
#730: FILE: hw/display/cirrus_vga.c:1446:
+ case 0x1d: // VCLK 2 Denominator & Post
ERROR: do not use C99 // comments
#731: FILE: hw/display/cirrus_vga.c:1447:
+ case 0x1e: // VCLK 3 Denominator & Post
ERROR: do not use C99 // comments
#732: FILE: hw/display/cirrus_vga.c:1448:
+ case 0x1f: // BIOS Write Enable and MCLK select
ERROR: do not use C99 // comments
#744: FILE: hw/display/cirrus_vga.c:1455:
+ case 0x12: // Graphics Cursor Attribute
WARNING: line over 80 characters
#754: FILE: hw/display/cirrus_vga.c:1463:
+ case 0x17: // Configuration Readback and Extended
Control
ERROR: do not use C99 // comments
#754: FILE: hw/display/cirrus_vga.c:1463:
+ case 0x17: // Configuration Readback and Extended
Control
ERROR: do not use C99 // comments
#814: FILE: hw/display/cirrus_vga.c:1555:
+ case 0x02: // Standard VGA
ERROR: do not use C99 // comments
#815: FILE: hw/display/cirrus_vga.c:1556:
+ case 0x03: // Standard VGA
ERROR: do not use C99 // comments
#816: FILE: hw/display/cirrus_vga.c:1557:
+ case 0x04: // Standard VGA
ERROR: do not use C99 // comments
#817: FILE: hw/display/cirrus_vga.c:1558:
+ case 0x06: // Standard VGA
ERROR: do not use C99 // comments
#818: FILE: hw/display/cirrus_vga.c:1559:
+ case 0x07: // Standard VGA
ERROR: do not use C99 // comments
#819: FILE: hw/display/cirrus_vga.c:1560:
+ case 0x08: // Standard VGA
ERROR: do not use C99 // comments
#822: FILE: hw/display/cirrus_vga.c:1562:
+ case 0x05: // Standard VGA, Cirrus extended mode
ERROR: do not use C99 // comments
#860: FILE: hw/display/cirrus_vga.c:1584:
+ case 0x00: // Standard VGA, BGCOLOR 0x000000ff
ERROR: do not use C99 // comments
#866: FILE: hw/display/cirrus_vga.c:1588:
+ case 0x01: // Standard VGA, FGCOLOR 0x000000ff
ERROR: do not use C99 // comments
#870: FILE: hw/display/cirrus_vga.c:1592:
+ case 0x02: // Standard VGA
ERROR: do not use C99 // comments
#871: FILE: hw/display/cirrus_vga.c:1593:
+ case 0x03: // Standard VGA
ERROR: do not use C99 // comments
#872: FILE: hw/display/cirrus_vga.c:1594:
+ case 0x04: // Standard VGA
ERROR: do not use C99 // comments
#873: FILE: hw/display/cirrus_vga.c:1595:
+ case 0x06: // Standard VGA
ERROR: do not use C99 // comments
#874: FILE: hw/display/cirrus_vga.c:1596:
+ case 0x07: // Standard VGA
ERROR: do not use C99 // comments
#875: FILE: hw/display/cirrus_vga.c:1597:
+ case 0x08: // Standard VGA
ERROR: do not use C99 // comments
#878: FILE: hw/display/cirrus_vga.c:1600:
+ case 0x05: // Standard VGA, Cirrus extended mode
ERROR: do not use C99 // comments
#888: FILE: hw/display/cirrus_vga.c:1604:
+ case 0x09: // bank offset #0
ERROR: do not use C99 // comments
#889: FILE: hw/display/cirrus_vga.c:1605:
+ case 0x0A: // bank offset #1
ERROR: do not use C99 // comments
#937: FILE: hw/display/cirrus_vga.c:1617:
+ case 0x10: // BGCOLOR 0x0000ff00
ERROR: do not use C99 // comments
#938: FILE: hw/display/cirrus_vga.c:1618:
+ case 0x11: // FGCOLOR 0x0000ff00
ERROR: do not use C99 // comments
#939: FILE: hw/display/cirrus_vga.c:1619:
+ case 0x12: // BGCOLOR 0x00ff0000
ERROR: do not use C99 // comments
#940: FILE: hw/display/cirrus_vga.c:1620:
+ case 0x13: // FGCOLOR 0x00ff0000
ERROR: do not use C99 // comments
#941: FILE: hw/display/cirrus_vga.c:1621:
+ case 0x14: // BGCOLOR 0xff000000
ERROR: do not use C99 // comments
#942: FILE: hw/display/cirrus_vga.c:1622:
+ case 0x15: // FGCOLOR 0xff000000
ERROR: do not use C99 // comments
#943: FILE: hw/display/cirrus_vga.c:1623:
+ case 0x20: // BLT WIDTH 0x0000ff
ERROR: do not use C99 // comments
#944: FILE: hw/display/cirrus_vga.c:1624:
+ case 0x22: // BLT HEIGHT 0x0000ff
ERROR: do not use C99 // comments
#945: FILE: hw/display/cirrus_vga.c:1625:
+ case 0x24: // BLT DEST PITCH 0x0000ff
ERROR: do not use C99 // comments
#946: FILE: hw/display/cirrus_vga.c:1626:
+ case 0x26: // BLT SRC PITCH 0x0000ff
ERROR: do not use C99 // comments
#947: FILE: hw/display/cirrus_vga.c:1627:
+ case 0x28: // BLT DEST ADDR 0x0000ff
ERROR: do not use C99 // comments
#948: FILE: hw/display/cirrus_vga.c:1628:
+ case 0x29: // BLT DEST ADDR 0x00ff00
ERROR: do not use C99 // comments
#949: FILE: hw/display/cirrus_vga.c:1629:
+ case 0x2c: // BLT SRC ADDR 0x0000ff
ERROR: do not use C99 // comments
#950: FILE: hw/display/cirrus_vga.c:1630:
+ case 0x2d: // BLT SRC ADDR 0x00ff00
ERROR: do not use C99 // comments
#951: FILE: hw/display/cirrus_vga.c:1631:
+ case 0x2f: // BLT WRITEMASK
ERROR: do not use C99 // comments
#952: FILE: hw/display/cirrus_vga.c:1632:
+ case 0x30: // BLT MODE
ERROR: do not use C99 // comments
#953: FILE: hw/display/cirrus_vga.c:1633:
+ case 0x32: // RASTER OP
ERROR: do not use C99 // comments
#954: FILE: hw/display/cirrus_vga.c:1634:
+ case 0x33: // BLT MODEEXT
ERROR: do not use C99 // comments
#955: FILE: hw/display/cirrus_vga.c:1635:
+ case 0x34: // BLT TRANSPARENT COLOR 0x00ff
ERROR: do not use C99 // comments
#956: FILE: hw/display/cirrus_vga.c:1636:
+ case 0x35: // BLT TRANSPARENT COLOR 0xff00
ERROR: do not use C99 // comments
#957: FILE: hw/display/cirrus_vga.c:1637:
+ case 0x38: // BLT TRANSPARENT COLOR MASK 0x00ff
ERROR: do not use C99 // comments
#958: FILE: hw/display/cirrus_vga.c:1638:
+ case 0x39: // BLT TRANSPARENT COLOR MASK 0xff00
ERROR: do not use C99 // comments
#961: FILE: hw/display/cirrus_vga.c:1641:
+ case 0x21: // BLT WIDTH 0x001f00
ERROR: do not use C99 // comments
#962: FILE: hw/display/cirrus_vga.c:1642:
+ case 0x23: // BLT HEIGHT 0x001f00
ERROR: do not use C99 // comments
#963: FILE: hw/display/cirrus_vga.c:1643:
+ case 0x25: // BLT DEST PITCH 0x001f00
ERROR: do not use C99 // comments
#964: FILE: hw/display/cirrus_vga.c:1644:
+ case 0x27: // BLT SRC PITCH 0x001f00
ERROR: do not use C99 // comments
#967: FILE: hw/display/cirrus_vga.c:1647:
+ case 0x2a: // BLT DEST ADDR 0x3f0000
ERROR: do not use C99 // comments
#981: FILE: hw/display/cirrus_vga.c:1654:
+ case 0x2e: // BLT SRC ADDR 0x3f0000
ERROR: do not use C99 // comments
#984: FILE: hw/display/cirrus_vga.c:1657:
+ case 0x31: // BLT STATUS/START
ERROR: do not use C99 // comments
#1030: FILE: hw/display/cirrus_vga.c:1678:
+ case 0x00: // Standard VGA
ERROR: do not use C99 // comments
#1031: FILE: hw/display/cirrus_vga.c:1679:
+ case 0x01: // Standard VGA
ERROR: do not use C99 // comments
#1032: FILE: hw/display/cirrus_vga.c:1680:
+ case 0x02: // Standard VGA
ERROR: do not use C99 // comments
#1033: FILE: hw/display/cirrus_vga.c:1681:
+ case 0x03: // Standard VGA
ERROR: do not use C99 // comments
#1034: FILE: hw/display/cirrus_vga.c:1682:
+ case 0x04: // Standard VGA
ERROR: do not use C99 // comments
#1035: FILE: hw/display/cirrus_vga.c:1683:
+ case 0x05: // Standard VGA
ERROR: do not use C99 // comments
#1036: FILE: hw/display/cirrus_vga.c:1684:
+ case 0x06: // Standard VGA
ERROR: do not use C99 // comments
#1037: FILE: hw/display/cirrus_vga.c:1685:
+ case 0x07: // Standard VGA
ERROR: do not use C99 // comments
#1038: FILE: hw/display/cirrus_vga.c:1686:
+ case 0x08: // Standard VGA
ERROR: do not use C99 // comments
#1039: FILE: hw/display/cirrus_vga.c:1687:
+ case 0x09: // Standard VGA
ERROR: do not use C99 // comments
#1040: FILE: hw/display/cirrus_vga.c:1688:
+ case 0x0a: // Standard VGA
ERROR: do not use C99 // comments
#1041: FILE: hw/display/cirrus_vga.c:1689:
+ case 0x0b: // Standard VGA
ERROR: do not use C99 // comments
#1042: FILE: hw/display/cirrus_vga.c:1690:
+ case 0x0c: // Standard VGA
ERROR: do not use C99 // comments
#1043: FILE: hw/display/cirrus_vga.c:1691:
+ case 0x0d: // Standard VGA
ERROR: do not use C99 // comments
#1044: FILE: hw/display/cirrus_vga.c:1692:
+ case 0x0e: // Standard VGA
ERROR: do not use C99 // comments
#1045: FILE: hw/display/cirrus_vga.c:1693:
+ case 0x0f: // Standard VGA
ERROR: do not use C99 // comments
#1046: FILE: hw/display/cirrus_vga.c:1694:
+ case 0x10: // Standard VGA
ERROR: do not use C99 // comments
#1047: FILE: hw/display/cirrus_vga.c:1695:
+ case 0x11: // Standard VGA
ERROR: do not use C99 // comments
#1048: FILE: hw/display/cirrus_vga.c:1696:
+ case 0x12: // Standard VGA
ERROR: do not use C99 // comments
#1049: FILE: hw/display/cirrus_vga.c:1697:
+ case 0x13: // Standard VGA
ERROR: do not use C99 // comments
#1050: FILE: hw/display/cirrus_vga.c:1698:
+ case 0x14: // Standard VGA
ERROR: do not use C99 // comments
#1051: FILE: hw/display/cirrus_vga.c:1699:
+ case 0x15: // Standard VGA
ERROR: do not use C99 // comments
#1052: FILE: hw/display/cirrus_vga.c:1700:
+ case 0x16: // Standard VGA
ERROR: do not use C99 // comments
#1053: FILE: hw/display/cirrus_vga.c:1701:
+ case 0x17: // Standard VGA
ERROR: do not use C99 // comments
#1054: FILE: hw/display/cirrus_vga.c:1702:
+ case 0x18: // Standard VGA
WARNING: line over 80 characters
#1056: FILE: hw/display/cirrus_vga.c:1704:
+ case 0x24: // Attribute Controller Toggle Readback
(R)
ERROR: do not use C99 // comments
#1056: FILE: hw/display/cirrus_vga.c:1704:
+ case 0x24: // Attribute Controller Toggle Readback
(R)
ERROR: do not use C99 // comments
#1070: FILE: hw/display/cirrus_vga.c:1706:
+ case 0x19: // Interlace End
ERROR: do not use C99 // comments
#1071: FILE: hw/display/cirrus_vga.c:1707:
+ case 0x1a: // Miscellaneous Control
ERROR: do not use C99 // comments
#1072: FILE: hw/display/cirrus_vga.c:1708:
+ case 0x1b: // Extended Display Control
ERROR: do not use C99 // comments
#1073: FILE: hw/display/cirrus_vga.c:1709:
+ case 0x1c: // Sync Adjust and Genlock
ERROR: do not use C99 // comments
#1074: FILE: hw/display/cirrus_vga.c:1710:
+ case 0x1d: // Overlay Extended Control
ERROR: do not use C99 // comments
#1075: FILE: hw/display/cirrus_vga.c:1711:
+ case 0x22: // Graphics Data Latches Readback (R)
ERROR: do not use C99 // comments
#1076: FILE: hw/display/cirrus_vga.c:1712:
+ case 0x25: // Part Status
ERROR: do not use C99 // comments
#1077: FILE: hw/display/cirrus_vga.c:1713:
+ case 0x27: // Part ID (R)
ERROR: do not use C99 // comments
#1079: FILE: hw/display/cirrus_vga.c:1715:
+ case 0x26: // Attribute Controller Index Readback
(R)
ERROR: do not use C99 // comments
#1139: FILE: hw/display/cirrus_vga.c:1729:
+ case 0x00: // Standard VGA
ERROR: do not use C99 // comments
#1140: FILE: hw/display/cirrus_vga.c:1730:
+ case 0x01: // Standard VGA
ERROR: do not use C99 // comments
#1141: FILE: hw/display/cirrus_vga.c:1731:
+ case 0x02: // Standard VGA
ERROR: do not use C99 // comments
#1142: FILE: hw/display/cirrus_vga.c:1732:
+ case 0x03: // Standard VGA
ERROR: do not use C99 // comments
#1143: FILE: hw/display/cirrus_vga.c:1733:
+ case 0x04: // Standard VGA
ERROR: do not use C99 // comments
#1144: FILE: hw/display/cirrus_vga.c:1734:
+ case 0x05: // Standard VGA
ERROR: do not use C99 // comments
#1145: FILE: hw/display/cirrus_vga.c:1735:
+ case 0x06: // Standard VGA
ERROR: do not use C99 // comments
#1146: FILE: hw/display/cirrus_vga.c:1736:
+ case 0x07: // Standard VGA
ERROR: do not use C99 // comments
#1147: FILE: hw/display/cirrus_vga.c:1737:
+ case 0x08: // Standard VGA
ERROR: do not use C99 // comments
#1148: FILE: hw/display/cirrus_vga.c:1738:
+ case 0x09: // Standard VGA
ERROR: do not use C99 // comments
#1149: FILE: hw/display/cirrus_vga.c:1739:
+ case 0x0a: // Standard VGA
ERROR: do not use C99 // comments
#1150: FILE: hw/display/cirrus_vga.c:1740:
+ case 0x0b: // Standard VGA
ERROR: do not use C99 // comments
#1151: FILE: hw/display/cirrus_vga.c:1741:
+ case 0x0c: // Standard VGA
ERROR: do not use C99 // comments
#1152: FILE: hw/display/cirrus_vga.c:1742:
+ case 0x0d: // Standard VGA
ERROR: do not use C99 // comments
#1153: FILE: hw/display/cirrus_vga.c:1743:
+ case 0x0e: // Standard VGA
ERROR: do not use C99 // comments
#1154: FILE: hw/display/cirrus_vga.c:1744:
+ case 0x0f: // Standard VGA
ERROR: do not use C99 // comments
#1155: FILE: hw/display/cirrus_vga.c:1745:
+ case 0x10: // Standard VGA
ERROR: do not use C99 // comments
#1156: FILE: hw/display/cirrus_vga.c:1746:
+ case 0x11: // Standard VGA
ERROR: do not use C99 // comments
#1157: FILE: hw/display/cirrus_vga.c:1747:
+ case 0x12: // Standard VGA
ERROR: do not use C99 // comments
#1158: FILE: hw/display/cirrus_vga.c:1748:
+ case 0x13: // Standard VGA
ERROR: do not use C99 // comments
#1159: FILE: hw/display/cirrus_vga.c:1749:
+ case 0x14: // Standard VGA
ERROR: do not use C99 // comments
#1160: FILE: hw/display/cirrus_vga.c:1750:
+ case 0x15: // Standard VGA
ERROR: do not use C99 // comments
#1161: FILE: hw/display/cirrus_vga.c:1751:
+ case 0x16: // Standard VGA
ERROR: do not use C99 // comments
#1162: FILE: hw/display/cirrus_vga.c:1752:
+ case 0x17: // Standard VGA
ERROR: do not use C99 // comments
#1163: FILE: hw/display/cirrus_vga.c:1753:
+ case 0x18: // Standard VGA
ERROR: braces {} are necessary for all arms of this statement
#1167: FILE: hw/display/cirrus_vga.c:1757:
+ if (s->vga.cr_index == 7)
[...]
ERROR: space required before the open parenthesis '('
#1172: FILE: hw/display/cirrus_vga.c:1762:
+ switch(s->vga.cr_index) {
ERROR: do not use C99 // comments
#1190: FILE: hw/display/cirrus_vga.c:1774:
+ case 0x19: // Interlace End
ERROR: do not use C99 // comments
#1191: FILE: hw/display/cirrus_vga.c:1775:
+ case 0x1a: // Miscellaneous Control
ERROR: do not use C99 // comments
#1192: FILE: hw/display/cirrus_vga.c:1776:
+ case 0x1b: // Extended Display Control
ERROR: do not use C99 // comments
#1193: FILE: hw/display/cirrus_vga.c:1777:
+ case 0x1c: // Sync Adjust and Genlock
ERROR: do not use C99 // comments
#1194: FILE: hw/display/cirrus_vga.c:1778:
+ case 0x1d: // Overlay Extended Control
ERROR: do not use C99 // comments
#1215: FILE: hw/display/cirrus_vga.c:1785:
+ case 0x22: // Graphics Data Latches Readback (R)
WARNING: line over 80 characters
#1216: FILE: hw/display/cirrus_vga.c:1786:
+ case 0x24: // Attribute Controller Toggle Readback
(R)
ERROR: do not use C99 // comments
#1216: FILE: hw/display/cirrus_vga.c:1786:
+ case 0x24: // Attribute Controller Toggle Readback
(R)
ERROR: do not use C99 // comments
#1217: FILE: hw/display/cirrus_vga.c:1787:
+ case 0x26: // Attribute Controller Index Readback
(R)
ERROR: do not use C99 // comments
#1218: FILE: hw/display/cirrus_vga.c:1788:
+ case 0x27: // Part ID (R)
ERROR: do not use C99 // comments
#1220: FILE: hw/display/cirrus_vga.c:1790:
+ case 0x25: // Part Status
ERROR: spaces required around that ':' (ctx:VxE)
#1221: FILE: hw/display/cirrus_vga.c:1791:
+ default:
^
ERROR: braces {} are necessary for all arms of this statement
#1953: FILE: hw/display/cirrus_vga.c:2598:
+ if (index < 21)
[...]
+ else
[...]
ERROR: do not use C99 // comments
#2236: FILE: hw/display/cirrus_vga.c:2896:
+ s->vga.sr[0x1F] = 0x2d; // MemClock
ERROR: do not use C99 // comments
#2243: FILE: hw/display/cirrus_vga.c:2902:
+ s->vga.sr[0x1F] = 0x22; // MemClock
total: 226 errors, 5 warnings, 2192 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden