qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 13/14] sdcard: Add a "validate-crc" property


From: Michael Walle
Subject: Re: [Qemu-devel] [PATCH v2 13/14] sdcard: Add a "validate-crc" property
Date: Mon, 21 May 2018 14:59:42 +0200
User-agent: Roundcube Webmail/1.2.3

Am 2018-05-09 05:46, schrieb Philippe Mathieu-Daudé:
Since not all modelled controllers use the CRC verification (which is
somehow expensive), let the controller have a configurable property
to enable verification.

So far only the Milkymist controller uses it.

This silent the Coverity warning:

  "Code block is unreachable because of the syntactic structure of the
code (CWE-561)"

and fixes the following issue:

- CID1005332 (hw/sd/sd.c::sd_req_crc_validate) Structurally dead code

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>

Tested-by: Michael Walle <address@hidden>

-michael



reply via email to

[Prev in Thread] Current Thread [Next in Thread]