[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 16/17] translate-all: remove tb_lock mention from
From: |
Emilio G. Cota |
Subject: |
[Qemu-devel] [PATCH v3 16/17] translate-all: remove tb_lock mention from cpu_restore_state_from_tb |
Date: |
Mon, 21 May 2018 19:39:26 -0400 |
tb_lock was needed when the function did retranslation. However,
since fca8a500d519 ("tcg: Save insn data and use it in
cpu_restore_state_from_tb") we don't do retranslation.
Get rid of the comment.
Reviewed-by: Richard Henderson <address@hidden>
Signed-off-by: Emilio G. Cota <address@hidden>
---
accel/tcg/translate-all.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c
index 031060f..6cc7b94 100644
--- a/accel/tcg/translate-all.c
+++ b/accel/tcg/translate-all.c
@@ -355,7 +355,6 @@ static int encode_search(TranslationBlock *tb, uint8_t
*block)
}
/* The cpu state corresponding to 'searched_pc' is restored.
- * Called with tb_lock held.
* When reset_icount is true, current TB will be interrupted and
* icount should be recalculated.
*/
--
2.7.4
- [Qemu-devel] [PATCH v3 00/17] tcg: tb_lock removal redux v3, Emilio G. Cota, 2018/05/21
- [Qemu-devel] [PATCH v3 04/17] tcg: move tb_ctx.tb_phys_invalidate_count to tcg_ctx, Emilio G. Cota, 2018/05/21
- [Qemu-devel] [PATCH v3 07/17] translate-all: remove hole in PageDesc, Emilio G. Cota, 2018/05/21
- [Qemu-devel] [PATCH v3 12/17] translate-all: introduce assert_no_pages_locked, Emilio G. Cota, 2018/05/21
- [Qemu-devel] [PATCH v3 06/17] translate-all: make l1_map lockless, Emilio G. Cota, 2018/05/21
- [Qemu-devel] [PATCH v3 08/17] translate-all: work page-by-page in tb_invalidate_phys_range_1, Emilio G. Cota, 2018/05/21
- [Qemu-devel] [PATCH v3 15/17] cputlb: remove tb_lock from tlb_flush functions, Emilio G. Cota, 2018/05/21
- [Qemu-devel] [PATCH v3 05/17] translate-all: iterate over TBs in a page with PAGE_FOR_EACH_TB, Emilio G. Cota, 2018/05/21
- [Qemu-devel] [PATCH v3 16/17] translate-all: remove tb_lock mention from cpu_restore_state_from_tb,
Emilio G. Cota <=
- [Qemu-devel] [PATCH v3 13/17] translate-all: discard TB when tb_link_page returns an existing matching TB, Emilio G. Cota, 2018/05/21
- [Qemu-devel] [PATCH v3 03/17] tcg: track TBs with per-region BST's, Emilio G. Cota, 2018/05/21
- [Qemu-devel] [PATCH v3 10/17] translate-all: use per-page locking in !user-mode, Emilio G. Cota, 2018/05/21
- [Qemu-devel] [PATCH v3 01/17] qht: require a default comparison function, Emilio G. Cota, 2018/05/21
- [Qemu-devel] [PATCH v3 09/17] translate-all: move tb_invalidate_phys_page_range up in the file, Emilio G. Cota, 2018/05/21
- [Qemu-devel] [PATCH v3 02/17] qht: return existing entry when qht_insert fails, Emilio G. Cota, 2018/05/21
- [Qemu-devel] [PATCH v3 17/17] tcg: remove tb_lock, Emilio G. Cota, 2018/05/21
- [Qemu-devel] [PATCH v3 11/17] translate-all: add page_locked assertions, Emilio G. Cota, 2018/05/21
- [Qemu-devel] [PATCH v3 14/17] translate-all: protect TB jumps with a per-destination-TB lock, Emilio G. Cota, 2018/05/21