[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 23/28] intel-iommu: only do page walk for MAP notifie
From: |
Michael S. Tsirkin |
Subject: |
[Qemu-devel] [PULL 23/28] intel-iommu: only do page walk for MAP notifiers |
Date: |
Wed, 23 May 2018 17:43:21 +0300 |
From: Peter Xu <address@hidden>
For UNMAP-only IOMMU notifiers, we don't need to walk the page tables.
Fasten that procedure by skipping the page table walk. That should
boost performance for UNMAP-only notifiers like vhost.
CC: QEMU Stable <address@hidden>
Signed-off-by: Peter Xu <address@hidden>
Reviewed-by: Michael S. Tsirkin <address@hidden>
Signed-off-by: Michael S. Tsirkin <address@hidden>
---
include/hw/i386/intel_iommu.h | 2 ++
hw/i386/intel_iommu.c | 44 ++++++++++++++++++++++++++++++++++++++-----
2 files changed, 41 insertions(+), 5 deletions(-)
diff --git a/include/hw/i386/intel_iommu.h b/include/hw/i386/intel_iommu.h
index 016e74b..156f35e 100644
--- a/include/hw/i386/intel_iommu.h
+++ b/include/hw/i386/intel_iommu.h
@@ -93,6 +93,8 @@ struct VTDAddressSpace {
IntelIOMMUState *iommu_state;
VTDContextCacheEntry context_cache_entry;
QLIST_ENTRY(VTDAddressSpace) next;
+ /* Superset of notifier flags that this address space has */
+ IOMMUNotifierFlag notifier_flags;
};
struct VTDBus {
diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index 8d4069d..38ccc74 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -138,6 +138,12 @@ static inline void vtd_iommu_unlock(IntelIOMMUState *s)
qemu_mutex_unlock(&s->iommu_lock);
}
+/* Whether the address space needs to notify new mappings */
+static inline gboolean vtd_as_has_map_notifier(VTDAddressSpace *as)
+{
+ return as->notifier_flags & IOMMU_NOTIFIER_MAP;
+}
+
/* GHashTable functions */
static gboolean vtd_uint64_equal(gconstpointer v1, gconstpointer v2)
{
@@ -1436,14 +1442,36 @@ static void
vtd_iotlb_page_invalidate_notify(IntelIOMMUState *s,
VTDAddressSpace *vtd_as;
VTDContextEntry ce;
int ret;
+ hwaddr size = (1 << am) * VTD_PAGE_SIZE;
QLIST_FOREACH(vtd_as, &(s->vtd_as_with_notifiers), next) {
ret = vtd_dev_to_context_entry(s, pci_bus_num(vtd_as->bus),
vtd_as->devfn, &ce);
if (!ret && domain_id == VTD_CONTEXT_ENTRY_DID(ce.hi)) {
- vtd_page_walk(&ce, addr, addr + (1 << am) * VTD_PAGE_SIZE,
- vtd_page_invalidate_notify_hook,
- (void *)&vtd_as->iommu, true, s->aw_bits);
+ if (vtd_as_has_map_notifier(vtd_as)) {
+ /*
+ * As long as we have MAP notifications registered in
+ * any of our IOMMU notifiers, we need to sync the
+ * shadow page table.
+ */
+ vtd_page_walk(&ce, addr, addr + size,
+ vtd_page_invalidate_notify_hook,
+ (void *)&vtd_as->iommu, true, s->aw_bits);
+ } else {
+ /*
+ * For UNMAP-only notifiers, we don't need to walk the
+ * page tables. We just deliver the PSI down to
+ * invalidate caches.
+ */
+ IOMMUTLBEntry entry = {
+ .target_as = &address_space_memory,
+ .iova = addr,
+ .translated_addr = 0,
+ .addr_mask = size - 1,
+ .perm = IOMMU_NONE,
+ };
+ memory_region_notify_iommu(&vtd_as->iommu, entry);
+ }
}
}
}
@@ -2383,6 +2411,9 @@ static void
vtd_iommu_notify_flag_changed(IOMMUMemoryRegion *iommu,
exit(1);
}
+ /* Update per-address-space notifier flags */
+ vtd_as->notifier_flags = new;
+
if (old == IOMMU_NOTIFIER_NONE) {
QLIST_INSERT_HEAD(&s->vtd_as_with_notifiers, vtd_as, next);
} else if (new == IOMMU_NOTIFIER_NONE) {
@@ -2891,8 +2922,11 @@ static void vtd_iommu_replay(IOMMUMemoryRegion
*iommu_mr, IOMMUNotifier *n)
PCI_FUNC(vtd_as->devfn),
VTD_CONTEXT_ENTRY_DID(ce.hi),
ce.hi, ce.lo);
- vtd_page_walk(&ce, 0, ~0ULL, vtd_replay_hook, (void *)n, false,
- s->aw_bits);
+ if (vtd_as_has_map_notifier(vtd_as)) {
+ /* This is required only for MAP typed notifiers */
+ vtd_page_walk(&ce, 0, ~0ULL, vtd_replay_hook, (void *)n, false,
+ s->aw_bits);
+ }
} else {
trace_vtd_replay_ce_invalid(bus_n, PCI_SLOT(vtd_as->devfn),
PCI_FUNC(vtd_as->devfn));
--
MST
- [Qemu-devel] [PULL 13/28] vhost-user: support receiving file descriptors in slave_read, (continued)
- [Qemu-devel] [PULL 13/28] vhost-user: support receiving file descriptors in slave_read, Michael S. Tsirkin, 2018/05/23
- [Qemu-devel] [PULL 11/28] linux-headers: add kvm header for mips, Michael S. Tsirkin, 2018/05/23
- [Qemu-devel] [PULL 16/28] libvhost-user: Send messages with no data, Michael S. Tsirkin, 2018/05/23
- [Qemu-devel] [PULL 15/28] vhost-user+postcopy: Use qemu_set_nonblock, Michael S. Tsirkin, 2018/05/23
- [Qemu-devel] [PULL 10/28] linux-headers: add unistd.h on all arches, Michael S. Tsirkin, 2018/05/23
- [Qemu-devel] [PULL 17/28] hw/virtio: Fix brace Werror with clang 6.0.0, Michael S. Tsirkin, 2018/05/23
- [Qemu-devel] [PULL 20/28] intel-iommu: send PSI always even if across PDEs, Michael S. Tsirkin, 2018/05/23
- [Qemu-devel] [PULL 19/28] nvdimm: fix typo in label-size definition, Michael S. Tsirkin, 2018/05/23
- [Qemu-devel] [PULL 18/28] contrib/vhost-user-blk: enable protocol feature for vhost-user-blk, Michael S. Tsirkin, 2018/05/23
- [Qemu-devel] [PULL 21/28] intel-iommu: remove IntelIOMMUNotifierNode, Michael S. Tsirkin, 2018/05/23
- [Qemu-devel] [PULL 23/28] intel-iommu: only do page walk for MAP notifiers,
Michael S. Tsirkin <=
- [Qemu-devel] [PULL 22/28] intel-iommu: add iommu lock, Michael S. Tsirkin, 2018/05/23
- [Qemu-devel] [PULL 24/28] intel-iommu: introduce vtd_page_walk_info, Michael S. Tsirkin, 2018/05/23
- [Qemu-devel] [PULL 26/28] intel-iommu: trace domain id during page walk, Michael S. Tsirkin, 2018/05/23
- [Qemu-devel] [PULL 27/28] util: implement simple iova tree, Michael S. Tsirkin, 2018/05/23
- [Qemu-devel] [PULL 28/28] intel-iommu: rework the page walk logic, Michael S. Tsirkin, 2018/05/23
- [Qemu-devel] [PULL 25/28] intel-iommu: pass in address space when page walk, Michael S. Tsirkin, 2018/05/23
- Re: [Qemu-devel] [PULL 00/28] pc, pci, virtio, vhost: fixes, features, Peter Maydell, 2018/05/24
- Re: [Qemu-devel] [PULL 00/28] pc, pci, virtio, vhost: fixes, features, no-reply, 2018/05/24