[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 6/8] linux-user: update ARCH_HAS_SOCKET_TYPES
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 6/8] linux-user: update ARCH_HAS_SOCKET_TYPES use |
|
Date: |
Thu, 24 May 2018 17:46:36 +0100 |
On 24 May 2018 at 16:50, Laurent Vivier <address@hidden> wrote:
> Le 24/05/2018 à 17:29, Laurent Vivier a écrit :
>> Le 21/05/2018 à 11:19, Peter Maydell a écrit :
>>> On 19 May 2018 at 10:29, Laurent Vivier <address@hidden> wrote:
>>>> to be like in the kernel and rename it TARGET_ARCH_HAS_SOCKET_TYPES
>>>
>>> You could note in the commit message that this fixes our
>>> incorrect definition of TARGET_SOCK_CLOEXEC for SPARC.
>>
>> I agree
>
> In fact it doesn't change the value of TARGET_SOCK_CLOEXEC for SPARC,
> because original value is 020000000 (0x400000) and the new value from
> linux-user/socket.h is TARGET_O_CLOEXEC which is also 0x400000 for SPARC.
Argh, octal vs hex. Thanks for checking that.
-- PMM
- [Qemu-devel] [PATCH v3 0/8] linux-user: move socket.h definitions to CPU directories, Laurent Vivier, 2018/05/19
- [Qemu-devel] [PATCH v3 1/8] linux-user: move mips socket.h definitions to mips/sockbits.h, Laurent Vivier, 2018/05/19
- [Qemu-devel] [PATCH v3 3/8] linux-user: move sparc/sparc64 socket.h definitions to sparc/sockbits.h, Laurent Vivier, 2018/05/19
- [Qemu-devel] [PATCH v3 8/8] linux-user: define TARGET_SO_REUSEPORT, Laurent Vivier, 2018/05/19
- [Qemu-devel] [PATCH v3 2/8] linux-user: move alpha socket.h definitions to alpha/sockbits.h, Laurent Vivier, 2018/05/19
- [Qemu-devel] [PATCH v3 6/8] linux-user: update ARCH_HAS_SOCKET_TYPES use, Laurent Vivier, 2018/05/19
[Qemu-devel] [PATCH v3 7/8] linux-user: copy sparc/sockbits.h definitions from linux, Laurent Vivier, 2018/05/19
[Qemu-devel] [PATCH v3 4/8] linux-user: move socket.h generic definitions to generic/sockbits.h, Laurent Vivier, 2018/05/19
[Qemu-devel] [PATCH v3 5/8] linux-user: move ppc socket.h definitions to ppc/sockbits.h, Laurent Vivier, 2018/05/19
Re: [Qemu-devel] [PATCH v3 0/8] linux-user: move socket.h definitions to CPU directories, no-reply, 2018/05/21