qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 1/1] sandbox: disable -sandbox if CONFIG_SECC


From: Yi Min Zhao
Subject: Re: [Qemu-devel] [PATCH v2 1/1] sandbox: disable -sandbox if CONFIG_SECCOMP undefined
Date: Fri, 25 May 2018 12:23:12 +0800
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:52.0) Gecko/20100101 Thunderbird/52.8.0



在 2018/5/24 下午9:40, Paolo Bonzini 写道:
On 24/05/2018 09:53, Eduardo Otubo wrote:
Thanks! But I have not got response from Paolo.  I have added him to
CC list.

  I'll just wait one more ACK and will send a pull request on the
seccomp queue. Thanks for the contribution.


So... what I should do is wait?

Yes, even though I think we're safe to proceed without his explicit ack.
The patch is okay; however, as a follow-up, you could consider moving
all the CONFIG_SECCOMP code to qemu-seccomp.c.

This way, the only #ifdef remains the one around qemu_opts_foreach.

Paolo


Thanks for your comment! Indeed, moving to the single C file is much more clear.
I will do this after this patch.

@Otubo, what about next step?




reply via email to

[Prev in Thread] Current Thread [Next in Thread]