Re: [Qemu-devel] [PULL 00/13] Linux user for 2.13 patches

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PULL 00/13] Linux user for 2.13 patches

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 t [tag update]            patchew/address@hidden -> patchew/address@hidden
 * [new tag]               patchew/address@hidden -> patchew/address@hidden
Switched to a new branch 'test'
24c7b0ddb2 gdbstub: Clarify what gdb_handlesig() is doing
61f5c7fadc linux-user: define TARGET_SO_REUSEPORT
30cf3523d7 linux-user: copy sparc/sockbits.h definitions from linux
32ab86798f linux-user: update ARCH_HAS_SOCKET_TYPES use
3c1e115f6e linux-user: move ppc socket.h definitions to ppc/sockbits.h
32a8b19493 linux-user: move socket.h generic definitions to generic/sockbits.h
c6a3d6b023 linux-user: move sparc/sparc64 socket.h definitions to 
sparc/sockbits.h
527209a2a1 linux-user: move alpha socket.h definitions to alpha/sockbits.h
612daca98f linux-user: move mips socket.h definitions to mips/sockbits.h
e4528ca200 linux-user: Fix payload size logic in host_to_target_cmsg()
576a0f83f2 linux-user: update comments to point to tcg_exec_init()
d7cf851bfe linux-user: update netlink emulation
d02fe9b4f1 linux-user: Assert on bad type in thunk_type_align() and 
thunk_type_size()

=== OUTPUT BEGIN ===
Checking PATCH 1/13: linux-user: Assert on bad type in thunk_type_align() and 
thunk_type_size()...
Checking PATCH 2/13: linux-user: update netlink emulation...
Checking PATCH 3/13: linux-user: update comments to point to tcg_exec_init()...
Checking PATCH 4/13: linux-user: Fix payload size logic in 
host_to_target_cmsg()...
Checking PATCH 5/13: linux-user: move mips socket.h definitions to 
mips/sockbits.h...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#18: 
new file mode 100644

ERROR: if this code is redundant consider removing it
#53: FILE: linux-user/mips/sockbits.h:31:
+#if 0

total: 1 errors, 1 warnings, 227 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 6/13: linux-user: move alpha socket.h definitions to 
alpha/sockbits.h...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#19: 
new file mode 100644

total: 0 errors, 1 warnings, 224 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 7/13: linux-user: move sparc/sparc64 socket.h definitions to 
sparc/sockbits.h...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#75: 
new file mode 100644

total: 0 errors, 1 warnings, 146 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 8/13: linux-user: move socket.h generic definitions to 
generic/sockbits.h...
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#15: 
new file mode 100644

total: 0 errors, 1 warnings, 148 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 9/13: linux-user: move ppc socket.h definitions to 
ppc/sockbits.h...
Checking PATCH 10/13: linux-user: update ARCH_HAS_SOCKET_TYPES use...
Checking PATCH 11/13: linux-user: copy sparc/sockbits.h definitions from 
linux...
Checking PATCH 12/13: linux-user: define TARGET_SO_REUSEPORT...
Checking PATCH 13/13: gdbstub: Clarify what gdb_handlesig() is doing...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden