[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 3/4] monitor: more comments on lock-free flei
From: |
Peter Xu |
Subject: |
Re: [Qemu-devel] [PATCH v7 3/4] monitor: more comments on lock-free fleids/funcs |
Date: |
Mon, 28 May 2018 14:28:54 +0800 |
User-agent: |
Mutt/1.9.5 (2018-04-13) |
On Thu, May 24, 2018 at 01:16:11PM +0200, Markus Armbruster wrote:
> Peter Xu <address@hidden> writes:
>
> > On Thu, May 24, 2018 at 10:41:09AM +0200, Markus Armbruster wrote:
> >> Regarding the subject: what are "fleids"?
> >
> > Ouch. :( I meant the word "fields".
>
> Can touch that up in my tree.
[...]
> >> > + /*
> >> > + * State used only in the thread "owning" the monitor.
> >> > + * If @use_io_thr, this is mon_global.mon_iothread.
> >> > + * Else, it's the main thread.
> >> > + * These members can be safely accessed without locks.
> >> > + */
> >> > ReadLineState *rs;
> >> > + // other members that aren't shared
> >>
> >> Whoops, misunderstanding! I meant this line as a placeholder, to
> >> further illustrate my intent. It should not be committed. If we need a
> >> comment here, it should use /* traditional comment syntax */.
> >
> > My fault.
> >
> > Please let me know if you want me to repost... Thanks,
>
> Can touch that up, too. No respin needed unless something more complex
> comes up.
I'll modify these two parts in my next post.
Regards,
--
Peter Xu
- Re: [Qemu-devel] [PATCH v7 1/4] monitor: rename out_lock to mon_lock, (continued)
[Qemu-devel] [PATCH v7 2/4] monitor: protect mon->fds with mon_lock, Peter Xu, 2018/05/24
[Qemu-devel] [PATCH v7 3/4] monitor: more comments on lock-free fleids/funcs, Peter Xu, 2018/05/24
[Qemu-devel] [PATCH v7 4/4] monitor: add lock to protect mon_fdsets, Peter Xu, 2018/05/24
Re: [Qemu-devel] [PATCH v7 4/4] monitor: add lock to protect mon_fdsets, Stefan Hajnoczi, 2018/05/24
Re: [Qemu-devel] [PATCH v7 0/4] monitor: let Monitor be thread safe, no-reply, 2018/05/24