[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 01/12] numa: clarify error message when node index is
From: |
Eduardo Habkost |
Subject: |
[Qemu-devel] [PULL 01/12] numa: clarify error message when node index is out of range in -numa dist, ... |
Date: |
Wed, 30 May 2018 20:05:17 -0300 |
From: Igor Mammedov <address@hidden>
When using following CLI:
-numa dist,src=128,dst=1,val=20
user gets a rather confusing error message:
"Invalid node 128, max possible could be 128"
Where 128 is number of nodes that QEMU supports (MAX_NODES),
while src/dst is an index up to that limit, so it should be
MAX_NODES - 1 in error message.
Make error message to explicitly state valid range for node
index to be more clear.
Signed-off-by: Igor Mammedov <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Eric Blake <address@hidden>
Signed-off-by: Eduardo Habkost <address@hidden>
---
numa.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/numa.c b/numa.c
index aac22a9612..efc78b2f17 100644
--- a/numa.c
+++ b/numa.c
@@ -141,9 +141,8 @@ static void parse_numa_distance(NumaDistOptions *dist,
Error **errp)
uint8_t val = dist->val;
if (src >= MAX_NODES || dst >= MAX_NODES) {
- error_setg(errp,
- "Invalid node %d, max possible could be %d",
- MAX(src, dst), MAX_NODES);
+ error_setg(errp, "Parameter '%s' expects an integer between 0 and %d",
+ src >= MAX_NODES ? "src" : "dst", MAX_NODES - 1);
return;
}
--
2.17.1
- [Qemu-devel] [PULL 00/12] NUMA queue, 2018-05-30, Eduardo Habkost, 2018/05/30
- [Qemu-devel] [PULL 01/12] numa: clarify error message when node index is out of range in -numa dist, ...,
Eduardo Habkost <=
- [Qemu-devel] [PULL 02/12] numa: postpone options post-processing till machine_run_board_init(), Eduardo Habkost, 2018/05/30
- [Qemu-devel] [PULL 03/12] numa: split out NumaOptions parsing into set_numa_options(), Eduardo Habkost, 2018/05/30
- [Qemu-devel] [PULL 04/12] qapi: introduce preconfig runstate, Eduardo Habkost, 2018/05/30
- [Qemu-devel] [PULL 05/12] hmp: disable monitor in preconfig state, Eduardo Habkost, 2018/05/30
- [Qemu-devel] [PULL 06/12] qapi: introduce new cmd option "allow-preconfig", Eduardo Habkost, 2018/05/30
- [Qemu-devel] [PULL 07/12] tests: qapi-schema tests for allow-preconfig, Eduardo Habkost, 2018/05/30
- [Qemu-devel] [PULL 09/12] tests: extend qmp test with preconfig checks, Eduardo Habkost, 2018/05/30
- [Qemu-devel] [PULL 08/12] cli: add --preconfig option, Eduardo Habkost, 2018/05/30
- [Qemu-devel] [PULL 10/12] qmp: permit query-hotpluggable-cpus in preconfig state, Eduardo Habkost, 2018/05/30
- [Qemu-devel] [PULL 11/12] qmp: add set-numa-node command, Eduardo Habkost, 2018/05/30