Re: [Qemu-devel] [PATCH 00/20] target/openrisc improvements

[Stafford Horne]

On Sun, May 27, 2018 at 09:13:04AM -0500, Richard Henderson wrote:
> This is almost a grab-bag of little improvements to the port.
> 
> patches 1-3:
>   Fix singlestepping for gdbstub.  This has apparently never
>   worked, as the first commit has the same bug of not advancing
>   the pc when stepping.

This is a big cleanup, thanks.

> patches 4-5:
>   Exit the TB after l.mtspr insns.  In particular, storing to
>   SR changes exception state so we want to return to the main
>   loop to recognize any pending interrupts immediately.

CC'ing Davidson

This might explain part of the problem he was seeing with setting PICMR.

> patches 6-19:
>   Reorganize TLB handling.  There is a fundamental bug that is
>   fixed in patch 13.  However the bug has been hidden by extra
>   TLB flushing elsewhere in the port.  I remove some unnecessary
>   indirection that the port inherited from somewhere -- probably
>   the MIPS port.  Finally, I present the QEMU TLB a unified view
>   of the OpenRISC split I/D TLB.
> 
> patch 20:
>   Split out disassembly from translation.
> 
> patch 21:
>   Add qemu-or1k to qemu-binfmt-conf.sh.

Again, I have nothing in my queue if you can send the pull request it would be
appreciated, if not let me know.

I will reply on the individual patches too, Give me some time, I reviewed on my
phone.

Thanks,

-Stafford