Re: [Qemu-devel] [PULL 00/53] Misc patches for 2018-05-31

[Peter Maydell]

On 31 May 2018 at 18:12, Paolo Bonzini <address@hidden> wrote:
> The following changes since commit 5a5c383b1373aeb6c87a0d6060f6c3dc7c53082b:
>
>   Merge remote-tracking branch 
> 'remotes/vivier2/tags/linux-user-for-2.13-pull-request' into staging 
> (2018-05-25 10:04:36 +0100)
>
> are available in the Git repository at:
>
>   git://github.com/bonzini/qemu.git tags/for-upstream
>
> for you to fetch changes up to 2904754bc2ed976acba66a10cb241d23c24b9bcb:
>
>   memory: Make operations using MemoryRegionIoeventfd struct pass by pointer. 
> (2018-05-31 19:12:13 +0200)
>
> ----------------------------------------------------------------
> * Linux header upgrade (Peter)
> * firmware.json definition (Laszlo)
> * IPMI migration fix (Corey)
> * QOM improvements (Alexey, Philippe, me)
> * Memory API cleanups (Jay, me, Tristan, Peter)
> * WHPX fixes and improvements (Lucian)
> * Chardev fixes (Marc-André)
> * IOMMU documentation improvements (Peter)
> * Coverity fixes (Peter, Philippe)
> * Include cleanup (Philippe)
> * -clock deprecation (Thomas)
> * Disable -sandbox unless CONFIG_SECCOMP (Yi Min Zhao)
>
> ----------------------------------------------------------------

Hi. This produces new warnings building on netbsd:

  CC      x86_64-bsd-user/bsd-user/mmap.o
/root/qemu/bsd-user/mmap.c:30:6: warning: no previous prototype for
'mmap_lock' [-Wmissing-prototypes]
 void mmap_lock(void)
      ^
/root/qemu/bsd-user/mmap.c:37:6: warning: no previous prototype for
'mmap_unlock' [-Wmissing-prototypes]
 void mmap_unlock(void)
      ^
/root/qemu/bsd-user/mmap.c:44:6: warning: no previous prototype for
'have_mmap_lock' [-Wmissing-prototypes]
 bool have_mmap_lock(void)
      ^

(ditto for the other *-bsd-user targets)

I assume that bsd-user/mmap.c was previously relying on some
header file dragging in exec-all.h for it, and that is no
longer happening.

thanks
-- PMM