Re: [Qemu-devel] [PATCH v2 05/20] 9p: Properly set errp in fstatfs error path

[Greg Kurz]

On Thu, 31 May 2018 21:26:00 -0400
Keno Fischer <address@hidden> wrote:

> In the review of
> 
>     9p: Avoid warning if FS_IOC_GETVERSION is not defined
> 
> Grep Kurz noted this error path was failing to set errp.
> Fix that.
> 
> Signed-off-by: Keno Fischer <address@hidden>
> ---

This is a bug fix so I've applied it to 9p-next.

Thanks!

> 
> Changes since v1: New patch
> 
>  hw/9pfs/9p-local.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/hw/9pfs/9p-local.c b/hw/9pfs/9p-local.c
> index adc169a..576c8e3 100644
> --- a/hw/9pfs/9p-local.c
> +++ b/hw/9pfs/9p-local.c
> @@ -1420,6 +1420,8 @@ static int local_init(FsContext *ctx, Error **errp)
>       */
>      if (fstatfs(data->mountfd, &stbuf) < 0) {
>          close_preserve_errno(data->mountfd);
> +        error_setg_errno(errp, errno,
> +            "failed to stat file system at '%s'", ctx->fs_root);
>          goto err;
>      }
>      switch (stbuf.f_type) {