[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 15/20] 9p: darwin: *xattr_nofollow implementa
|
From: |
Keno Fischer |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 15/20] 9p: darwin: *xattr_nofollow implementations |
|
Date: |
Sat, 2 Jun 2018 16:01:54 -0400 |
> I guess this calls for some defines in 9p.h:
>
> /* 9p2000.L says that the 'flags' argument of operation 'xattrcreate'
> * are derived from Linux setxattr.
> */
> #define P9_XATTR_CREATE 1
> #define P9_XATTR_REPLACE 2
>
> Please do that in a preparatory patch.
>
> I would also appreciate you look at other 9P operations and
> check if we have other places where we need to translate
> some flags.
I will include this additional patch in the next respin of the series.
I took a look at the remaining protocol messages and it looks
like with the exception of this and unlinkat (the other patch in the
series), flags/open modes are translated properly.