Re: [Qemu-devel] [PATCH] vl: don't use RUN_STATE_PRECONFIG unless --preconfig is given

[Daniel P . Berrangé]

On Mon, Jun 04, 2018 at 01:58:02PM +0200, Igor Mammedov wrote:
> On Mon, 4 Jun 2018 12:33:04 +0200
> Max Reitz <address@hidden> wrote:
> 
> > On 2018-06-04 12:27, Daniel P. Berrangé wrote:
> > > The RUN_STATE_PRECONFIG state is not supposed to be reachable unless the
> > > --preconfig argument is given to QEMU, but when it was introduced in:
> > > 
> > >   commit 047f7038f586d2150f16c6d9ba9cfd0479f0f6ac
> > >   Author: Igor Mammedov <address@hidden>
> > >   Date:   Fri May 11 19:24:43 2018 +0200
> > > 
> > >     cli: add --preconfig option
> > > 
> > > The global 'current_run_state' variable was changed to have an initial
> > > value of RUN_STATE_PRECONFIG regardless of whether --preconfig is given.
> That was intentional, see 8a36283e12 commit message which has it right.
> I should fix doc comment qapi/run-state.json though as it's misleading
> (I've meant it reachable for user, while doc comment applies to
> not only to user but to qemu internals as well).
> I'll post a patch to clarify doc comment.
> 
> Idea behind PRECONFIG runstate is to start spitting PRELAUNCH
> runstate (which is historically ended up as a dump for almost everything)
> into smaller more manageable part.

I know it was intentional, but it is still undesirable, as it results in
need for bogus transitions to INMIGRATE, as well as the problems mentioned
by Michael and Max. IIUC this can all be solved by introducing a further
RUN_STATE_NONE to act as the initial value, avoiding the visibilty of
RUN_STATE_PRECONFIG unless actually requested. I've sent a further patch
that does this.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|