[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 2/2] vl: fix use of --daemonize with --precon
From: |
Eduardo Habkost |
Subject: |
Re: [Qemu-devel] [PATCH v5 2/2] vl: fix use of --daemonize with --preconfig |
Date: |
Wed, 6 Jun 2018 10:50:51 -0300 |
User-agent: |
Mutt/1.9.2 (2017-12-15) |
On Wed, Jun 06, 2018 at 10:37:05AM +0200, Igor Mammedov wrote:
[...]
> @@ -4578,6 +4579,13 @@ int main(int argc, char **argv, char **envp)
> parse_numa_opts(current_machine);
>
> /* do monitor/qmp handling at preconfig state if requested */
> + if (!preconfig_exit_requested && is_daemonized()) {
> + /* signal parent QEMU to exit, libvirt treats it as a sign
> + * that monitor socket is ready to accept connections
> + */
> + os_setup_post();
> + os_setup_post_done = true;
> + }
I liked your version of os_setup_post() in v3, where the
os_setup_post_done check is done inside os_setup_post().
> main_loop();
>
> /* from here on runstate is RUN_STATE_PRELAUNCH */
> @@ -4707,8 +4715,10 @@ int main(int argc, char **argv, char **envp)
> }
>
> accel_setup_post(current_machine);
> - os_setup_post();
>
> + if (!os_setup_post_done) {
> + os_setup_post();
> + }
> main_loop();
>
> gdbserver_cleanup();
> --
> 2.7.4
>
--
Eduardo
- [Qemu-devel] [PATCH v3 1/2] cli: Don't run early event loop if no --preconfig was specified, (continued)
- [Qemu-devel] [PATCH v3 2/2] vl: fix use of --daemonize with --preconfig, Igor Mammedov, 2018/06/05
- Re: [Qemu-devel] [PATCH v3 2/2] vl: fix use of --daemonize with --preconfig, Eric Blake, 2018/06/05
- Re: [Qemu-devel] [PATCH v3 2/2] vl: fix use of --daemonize with --preconfig, Eduardo Habkost, 2018/06/05
- Re: [Qemu-devel] [PATCH v3 2/2] vl: fix use of --daemonize with --preconfig, Igor Mammedov, 2018/06/06
- [Qemu-devel] [PATCH v5 2/2] vl: fix use of --daemonize with --preconfig, Igor Mammedov, 2018/06/06
- Re: [Qemu-devel] [PATCH v5 2/2] vl: fix use of --daemonize with --preconfig,
Eduardo Habkost <=
- [Qemu-devel] [PATCH v6 2/2] vl: fix use of --daemonize with --preconfig, Igor Mammedov, 2018/06/07
- Re: [Qemu-devel] [PATCH v6 2/2] vl: fix use of --daemonize with --preconfig, Eduardo Habkost, 2018/06/08
- Re: [Qemu-devel] [PATCH v6 2/2] vl: fix use of --daemonize with --preconfig, Igor Mammedov, 2018/06/11
- Re: [Qemu-devel] [PATCH v6 2/2] vl: fix use of --daemonize with --preconfig, Eduardo Habkost, 2018/06/11
- Re: [Qemu-devel] [PATCH v6 2/2] vl: fix use of --daemonize with --preconfig, Igor Mammedov, 2018/06/11
- Re: [Qemu-devel] [PATCH v6 2/2] vl: fix use of --daemonize with --preconfig, Eduardo Habkost, 2018/06/11
- Re: [Qemu-devel] [libvirt] [PATCH v6 2/2] vl: fix use of --daemonize with --preconfig, Michal Privoznik, 2018/06/12
- Re: [Qemu-devel] [libvirt] [PATCH v6 2/2] vl: fix use of --daemonize with --preconfig, Igor Mammedov, 2018/06/12
- Re: [Qemu-devel] [libvirt] [PATCH v6 2/2] vl: fix use of --daemonize with --preconfig, Daniel P . Berrangé, 2018/06/12
- Re: [Qemu-devel] [libvirt] [PATCH v6 2/2] vl: fix use of --daemonize with --preconfig, Eduardo Habkost, 2018/06/13