[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/3] glib: bump min required glib library ver
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/3] glib: bump min required glib library version to 2.40 |
Date: |
Thu, 7 Jun 2018 07:46:28 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 |
On 06.06.2018 19:32, Daniel P. Berrangé wrote:
> Per supported platforms doc, the various min glib on relevant distros is:
>
> RHEL-7: 2.50.3
> Debian (Stretch): 2.50.3
> Debian (Jessie): 2.42.1
> OpenBSD (Ports): 2.54.3
> FreeBSD (Ports): 2.50.3
> OpenSUSE Leap 15: 2.54.3
> Ubuntu (Xenial): 2.48.0
> macOS (Homebrew): 2.56.0
>
> This suggests that a minimum glib of 2.42 is a reasonable target.
>
> The GLibC compile farm, however, uses Ubuntu 14.04 (Trusty) which only
> has glib 2.40.0, and this is needed for testing during merge. Thus an
> exception is made to the documented platform support policy to allow for
> all three current LTS releases to be supported.
>
> Signed-off-by: Daniel P. Berrangé <address@hidden>
> ---
> configure | 6 +-
> crypto/hash-glib.c | 4 -
> crypto/hmac-glib.c | 36 -----
> include/glib-compat.h | 319 ----------------------------------------
> qga/commands.c | 11 +-
> tests/ivshmem-test.c | 6 -
> tests/test-qmp-event.c | 8 +-
> tests/tpm-emu.h | 4 +-
> tests/vhost-user-test.c | 26 +---
> trace/simple.c | 6 +-
> util/osdep.c | 14 --
> 11 files changed, 11 insertions(+), 429 deletions(-)
Great diffstat!
And the changes look fine to me:
Reviewed-by: Thomas Huth <address@hidden>
[Qemu-devel] [PATCH v2 2/3] glib: enforce the minimum required version and warn about old APIs, Daniel P . Berrangé, 2018/06/06
[Qemu-devel] [PATCH v2 3/3] util: remove redundant include of glib.h, Daniel P . Berrangé, 2018/06/06