[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig |
Date: |
Thu, 7 Jun 2018 11:39:31 +0200 |
On Tue, 5 Jun 2018 13:26:34 +0100
"Dr. David Alan Gilbert (git)" <address@hidden> wrote:
> From: "Dr. David Alan Gilbert" <address@hidden>
>
> Allow a bunch of the info commands to be used in preconfig.
> Could probably add most of them.
>
> Signed-off-by: Dr. David Alan Gilbert <address@hidden>
> ---
> hmp-commands-info.hx | 9 +++++++++
> hmp-commands.hx | 1 +
> 2 files changed, 10 insertions(+)
>
> diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx
> index ddfcd5adcc..00735e7d1c 100644
> --- a/hmp-commands-info.hx
> +++ b/hmp-commands-info.hx
> @@ -19,6 +19,7 @@ ETEXI
> .params = "",
> .help = "show the version of QEMU",
> .cmd = hmp_info_version,
> + .flags = "p",
> },
>
> STEXI
> @@ -33,6 +34,7 @@ ETEXI
> .params = "",
> .help = "show the network state",
> .cmd = hmp_info_network,
> + .flags = "p",
output seems to refer to frontend devices, so we probably should skip this one
> },
>
> STEXI
> @@ -47,6 +49,7 @@ ETEXI
> .params = "",
> .help = "show the character devices",
> .cmd = hmp_info_chardev,
> + .flags = "p",
> },
>
> STEXI
> @@ -62,6 +65,7 @@ ETEXI
> .help = "show info of one block device or all block devices "
> "(-n: show named nodes; -v: show details)",
> .cmd = hmp_info_block,
> + .flags = "p",
> },
Devices (frontends) are processed after preconfig point,
so there isn't point in enabling this.
At least until we could instantiate devices at that time.
>
> STEXI
> @@ -151,6 +155,7 @@ ETEXI
> .params = "",
> .help = "show infos for each CPU",
> .cmd = hmp_info_cpus,
> + .flags = "p",
> },
this command probably shouldn't be enabled, there can't be any CPUs at this
point yet.
>
> STEXI
> @@ -165,6 +170,7 @@ ETEXI
> .params = "",
> .help = "show the command line history",
> .cmd = hmp_info_history,
> + .flags = "p",
> },
>
> STEXI
> @@ -255,6 +261,7 @@ ETEXI
> .help = "show memory tree (-f: dump flat view for address
> spaces;"
> "-d: dump dispatch tree, valid with -f only)",
> .cmd = hmp_info_mtree,
> + .flags = "p",
> },
probably we should skip this one as well
>
> STEXI
> @@ -399,6 +406,7 @@ ETEXI
> .params = "",
> .help = "show the current VM status (running|paused)",
> .cmd = hmp_info_status,
> + .flags = "p",
> },
>
> STEXI
> @@ -829,6 +837,7 @@ ETEXI
> .params = "",
> .help = "Show information about hotpluggable CPUs",
> .cmd = hmp_hotpluggable_cpus,
> + .flags = "p",
> },
>
> STEXI
> diff --git a/hmp-commands.hx b/hmp-commands.hx
> index 8bf590ae4b..dc82ed526f 100644
> --- a/hmp-commands.hx
> +++ b/hmp-commands.hx
> @@ -1856,6 +1856,7 @@ ETEXI
> .help = "show various information about the system state",
> .cmd = hmp_info_help,
> .sub_table = info_cmds,
> + .flags = "p",
> },
>
> STEXI
in addition to above we should be able to handle at preconfig time:
info memdev
info name
info numa
info qom-tree
info usbhost
info uuid
info iothreads
- Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig, (continued)
- Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig, Dr. David Alan Gilbert, 2018/06/07
- Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig, Markus Armbruster, 2018/06/07
- Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig, Dr. David Alan Gilbert, 2018/06/07
- Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig, Markus Armbruster, 2018/06/08
- Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig, Dr. David Alan Gilbert, 2018/06/08
- Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig, Igor Mammedov, 2018/06/08
- Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig, Markus Armbruster, 2018/06/08
- Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig, Dr. David Alan Gilbert, 2018/06/08
- Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig, Igor Mammedov, 2018/06/07
- Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig, Markus Armbruster, 2018/06/08
Re: [Qemu-devel] [PATCH 4/6] hmp: Add info commands for preconfig,
Igor Mammedov <=
[Qemu-devel] [PATCH 5/6] hmp: add exit_preconfig, Dr. David Alan Gilbert (git), 2018/06/05
[Qemu-devel] [PATCH 6/6] hmp: Allow HMP in preconfig state again, Dr. David Alan Gilbert (git), 2018/06/05
Re: [Qemu-devel] [PATCH 0/6] Reenable hmp for preconfig mode, Peter Xu, 2018/06/07
Re: [Qemu-devel] [PATCH 0/6] Reenable hmp for preconfig mode, Igor Mammedov, 2018/06/07